Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
anomiex
left a comment
There was a problem hiding this comment.
Seems reasonable. Haven't tested.
Proposed changes
There was a site generating about 10% of Jetpack-related PHP warnings on WP Cloud, all looking like this:
As it turned out, they had a plugin that was registering the oEmbed providers like so:
Instead, it should have been like this:
This PR adds a
continueif index0is not set, and usesfalsefor index1if not set.Related product discussion/links
Does this pull request change what data or activity we track or use?
Testing instructions
First, add an
mu-plugin:https://en.wikipedia.org/wiki/RickrollingOn `trunk, you'll get an error from Jetpack. On this branch you will not.
Note that refreshing the editor will show a warning from Core; that's reported here:
https://core.trac.wordpress.org/ticket/65068