Newsletter: remove old Jetpack Settings newsletter UI by dsas · Pull Request #48092 · Automattic/jetpack

dsas · 2026-04-14T16:52:01Z

Fixes https://linear.app/a8c/issue/DOTCOM-16489

Proposed changes

Remove the old Newsletter settings UI from the Jetpack Settings React app (the whole _inc/client/newsletter/ set of sections, ~2200 lines). The new Jetpack > Newsletter settings page (from the newsletter package) has replaced it.
Keep a small redirect card at _inc/client/newsletter/index.jsx that surfaces in Jetpack Settings search results when users search for a newsletter-related term, pointing them to the new settings page.
Redirect the #/newsletter route in the Jetpack Settings SPA to admin.php?page=jetpack-newsletter so bookmarks and external links still work.
Remove the now-unused jetpack_wp_admin_newsletter_settings_enabled feature-flag filter across plugins/jetpack, packages/newsletter, packages/my-jetpack, and packages/jetpack-mu-wpcom. The new settings page is now always on.
Simplify Urls::get_newsletter_settings_url() (always returns the new wp-admin URL) and update its callers.
The jetpack_show_newsletter_menu_item filter continues to work for hiding the Jetpack > Newsletter menu item.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

All environments (self-hosted Jetpack, Atomic, Simple wpcom)

Visit Jetpack → Newsletter in wp-admin — the new React settings page should load at admin.php?page=jetpack-newsletter.
Visit Settings → Reading — the newsletter clarifying notice should still appear next to "For each post in a feed" and link to the new settings page.
On the wp-admin Dashboard, the Newsletter widget's "Newsletter settings" link should point to admin.php?page=jetpack-newsletter.

Self-hosted Jetpack and Atomic (not Simple — those sites don't expose Jetpack → Settings or My Jetpack)

Visit admin.php?page=jetpack#/newsletter directly — it should redirect to admin.php?page=jetpack-newsletter.
Go to Jetpack → Settings — confirm there is no "Newsletter" tab in the navigation.
Open Jetpack → My Jetpack, find the Newsletter product card, and click its "Manage" link — it should go to the new wp-admin settings page.
Add add_filter( 'jetpack_show_newsletter_menu_item', '__return_false' ); and confirm the Jetpack > Newsletter menu item is hidden, but admin.php?page=jetpack-newsletter still loads when visited directly.

Any environment

Go to https://wordpress.com/stats/subscribers/:siteSlug
You should see an "Add the Subscribe Block to your site" task that goes directly to the new url

github-actions · 2026-04-14T16:52:53Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the dotcom-16489-delete-any-newly-obsoleted-jetpack-code branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack dotcom-16489-delete-any-newly-obsoleted-jetpack-code

bin/jetpack-downloader test jetpack-mu-wpcom-plugin dotcom-16489-delete-any-newly-obsoleted-jetpack-code

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-04-14T16:53:17Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: May 5, 2026
- Code freeze: May 4, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2026-04-14T17:07:39Z

Code Coverage Summary

Coverage changed in 17 files. Only the first 5 are listed here.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/_inc/client/components/settings-card/index.jsx	59/129 (45.74%)	-3.10%	4 💔
projects/plugins/jetpack/_inc/client/state/connection/reducer.js	50/79 (63.29%)	-2.53%	2 ❤️‍🩹
projects/plugins/jetpack/_inc/client/state/modules/reducer.js	45/58 (77.59%)	-3.45%	2 ❤️‍🩹
projects/plugins/jetpack/_inc/client/components/settings-group/index.jsx	15/17 (88.24%)	-5.88%	1 ❤️‍🩹
projects/plugins/jetpack/_inc/client/lib/plans/constants.js	221/273 (80.95%)	-0.37%	1 ❤️‍🩹

Full summary · PHP report · JS report

_{If appropriate, add one of these labels to override the failing coverage check:

Covered by non-unit tests
Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.}

The newsletter package's wp-admin settings UI has replaced the old Jetpack Settings newsletter section, so remove the now-obsolete code and the `jetpack_wp_admin_newsletter_settings_enabled` feature-flag filter that gated the rollout. - Delete `_inc/client/newsletter/` and its references in nav, settings routing, and Redux state. - Keep the `/newsletter` route as an unconditional redirect to `admin.php?page=jetpack-newsletter` for bookmarks/external links. - Simplify the newsletter package, my-jetpack, and jetpack-mu-wpcom to unconditionally use the new settings URL and menu registration. - The `jetpack_show_newsletter_menu_item` filter continues to work.

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 14, 2026

dsas added 2 commits April 15, 2026 22:14

Fix NavigationSettings tests for removed Newsletter tab

37a3687

dsas force-pushed the dotcom-16489-delete-any-newly-obsoleted-jetpack-code branch from 40a9369 to 37a3687 Compare April 16, 2026 08:31

dsas marked this pull request as ready for review April 16, 2026 09:46

dsas self-assigned this Apr 16, 2026

dsas requested a review from a team April 16, 2026 09:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Newsletter: remove old Jetpack Settings newsletter UI#48092

Newsletter: remove old Jetpack Settings newsletter UI#48092
dsas wants to merge 2 commits intotrunkfrom
dotcom-16489-delete-any-newly-obsoleted-jetpack-code

dsas commented Apr 14, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

jp-launch-control bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

dsas commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

All environments (self-hosted Jetpack, Atomic, Simple wpcom)

Self-hosted Jetpack and Atomic (not Simple — those sites don't expose Jetpack → Settings or My Jetpack)

Any environment

Uh oh!

github-actions bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dsas commented Apr 14, 2026 •

edited

Loading

github-actions bot commented Apr 14, 2026 •

edited

Loading

github-actions bot commented Apr 14, 2026 •

edited

Loading

jp-launch-control bot commented Apr 14, 2026 •

edited

Loading