CRM: migrate workflow row Edit button to @wordpress/ui#48149
CRM: migrate workflow row Edit button to @wordpress/ui#48149
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so: Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
e1fd607 to
752ddcf
Compare
Proposed changes
Buttonfrom@automattic/jetpack-componentsforButtonfrom@wordpress/uiin the workflow row Edit action.variant="secondary"→variant="outline"per the new@wordpress/uiAPI.@wordpress/uito the CRM plugin's direct dependencies.Other information
First of a safe batch migrating Jetpack custom Button consumers to
@wordpress/uiButton. Mechanical prop map only (noisLoading,isDestructive,isExternalLink,href,icon,weight,fullWidthinvolved — those cases will be addressed in separate, deliberate PRs).Isolated Storybook comparison
Both Button variants rendered side-by-side in an isolated Storybook story — accurate representation of the visual delta for the secondary → outline mapping.
Real-admin screenshot attempted but the CRM Automations module is a paid extension (
extkey: automations, $79/year) gated behind thejetpack_crm_automations_load_uifilter. Not available on the vanilla WP.org install I used for the other PRs in this batch. The DOM-level change for this callsite (same@wordpress/uiButton primitive used in the Publicize + Protect PRs where real-screen captures are present) will render identically — the same@wordpress/uiButton withvariant="outline"is used in PR #48150 (Publicize) where you can see the outline variant rendered live.Testing instructions
jetpack_crm_automations_load_uifilter returning true).