Skip to content

Protect: migrate firewall upgrade prompt button to @wordpress/ui#48151

Draft
lezama wants to merge 1 commit intotrunkfrom
try/protect-firewall-upgrade-button-wp-ui
Draft

Protect: migrate firewall upgrade prompt button to @wordpress/ui#48151
lezama wants to merge 1 commit intotrunkfrom
try/protect-firewall-upgrade-button-wp-ui

Conversation

@lezama
Copy link
Copy Markdown
Contributor

@lezama lezama commented Apr 17, 2026

Part of #48160

Proposed changes

  • Swap the custom Button from @automattic/jetpack-components for Button from @wordpress/ui in the firewall upgrade prompt.
  • No prop changes — the button uses only className and onClick, and the default variant maps cleanly to @wordpress/ui's variant="solid" default.
  • Adds @wordpress/ui to the Protect plugin's direct dependencies.

Other information

  • Generate changelog entries for this PR (using AI).

First of a safe batch migrating Jetpack custom Button consumers to @wordpress/ui Button. Mechanical prop map only (no isLoading, isDestructive, isExternalLink, href, icon, weight, fullWidth involved — those cases will be addressed in separate, deliberate PRs).

Real-screen before / after

Captured on a live Jurassic Ninja site with Jetpack + Jetpack Protect installed, on the Firewall tab of the Protect admin (/wp-admin/admin.php?page=jetpack-protect#/firewall) on a free site (automatic rules not enabled → upgrade prompt renders).

Before — @automattic/jetpack-components Button After — @wordpress/ui Button
before after

Button classes went from components-button dops-button is-primary (Jetpack wrapper) to …__button …__is-brand …__is-solid (@wordpress/ui primitive). The second "Upgrade to enable…" button further down the page is a separate ContextualUpgradeTrigger component (not touched by this PR).

Isolated Storybook comparison

protect-firewall-upgrade

Testing instructions

  • Open the Jetpack Protect admin page on a site without the automatic firewall features enabled.
  • Navigate to the Firewall tab and verify the upgrade prompt button at the top renders and invokes the upgrade flow on click. Visual appearance will differ slightly (core @wordpress/ui solid style vs. the old @automattic/jetpack-components primary).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the try/protect-firewall-upgrade-button-wp-ui branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack try/protect-firewall-upgrade-button-wp-ui
bin/jetpack-downloader test jetpack-mu-wpcom-plugin try/protect-firewall-upgrade-button-wp-ui

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Apr 17, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 17, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 17, 2026
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control bot commented Apr 17, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant