Social: render JetpackFooter on all sites for parity with peer pages#48183
Social: render JetpackFooter on all sites for parity with peer pages#48183
Conversation
SocialAdminPage gated showFooter to isJetpackSelfHostedSite(), hiding the JetpackFooter on WP.com (Simple and Atomic). Every other Jetpack admin page (Newsletter, Search, Backup, Protect, VideoPress, Boost, Network Admin) renders the footer unconditionally, so Social was the lone exception. Drop the override so the default (true) applies. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Proposed changes
SocialAdminPagepassesshowFooter={ isJetpackSite }to<AdminPage>, whereisJetpackSite = isJetpackSelfHostedSite(). On WordPress.com (Simple and Atomic), this resolves tofalse, hiding the<JetpackFooter>.Every other Jetpack admin page — Newsletter, Search, Backup, Protect, VideoPress, Boost, Jetpack Network Admin — renders the footer unconditionally (the default). Social was the lone exception, creating a visible inconsistency on WordPress.com. This PR drops the override so
showFooterfalls back to itstruedefault.The
isJetpackSitevariable is still used two lines up for the "Use license key" action button and for gating the pricing page, so it stays; only theshowFooterprop is removed.Introduced in #41393 (2023). The original rationale (hiding "irrelevant UI" on WordPress.com) no longer holds now that the footer is standard chrome across all Jetpack admin surfaces.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
/wp-admin/admin.php?page=jetpack-social.admin.php?page=jetpack-newsletterandadmin.php?page=jetpack-search— all three should now present the same footer treatment.isJetpackSitecheck for that button is unchanged).🤖 Generated with Claude Code