Skip to content

Social: render JetpackFooter on all sites for parity with peer pages#48183

Merged
CGastrell merged 1 commit intotrunkfrom
fix/social-admin-page-restore-footer
Apr 19, 2026
Merged

Social: render JetpackFooter on all sites for parity with peer pages#48183
CGastrell merged 1 commit intotrunkfrom
fix/social-admin-page-restore-footer

Conversation

@CGastrell
Copy link
Copy Markdown
Contributor

Proposed changes

SocialAdminPage passes showFooter={ isJetpackSite } to <AdminPage>, where isJetpackSite = isJetpackSelfHostedSite(). On WordPress.com (Simple and Atomic), this resolves to false, hiding the <JetpackFooter>.

Every other Jetpack admin page — Newsletter, Search, Backup, Protect, VideoPress, Boost, Jetpack Network Admin — renders the footer unconditionally (the default). Social was the lone exception, creating a visible inconsistency on WordPress.com. This PR drops the override so showFooter falls back to its true default.

The isJetpackSite variable is still used two lines up for the "Use license key" action button and for gating the pricing page, so it stays; only the showFooter prop is removed.

Introduced in #41393 (2023). The original rationale (hiding "irrelevant UI" on WordPress.com) no longer holds now that the footer is standard chrome across all Jetpack admin surfaces.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  1. On a WordPress.com site (Simple or Atomic), open /wp-admin/admin.php?page=jetpack-social.
  2. Verify the Jetpack footer ("An Automattic Airline" + Jetpack logo) is now rendered, pinned at the bottom of the content column.
  3. Compare against admin.php?page=jetpack-newsletter and admin.php?page=jetpack-search — all three should now present the same footer treatment.
  4. On a self-hosted Jetpack site, verify nothing regresses — the footer was already rendering there, and should continue to.
  5. Verify the "Use license key" button still appears on self-hosted sites without paid Social features (the isJetpackSite check for that button is unchanged).

🤖 Generated with Claude Code

SocialAdminPage gated showFooter to isJetpackSelfHostedSite(), hiding
the JetpackFooter on WP.com (Simple and Atomic). Every other Jetpack
admin page (Newsletter, Search, Backup, Protect, VideoPress, Boost,
Network Admin) renders the footer unconditionally, so Social was the
lone exception. Drop the override so the default (true) applies.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/social-admin-page-restore-footer branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/social-admin-page-restore-footer

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 19, 2026
@CGastrell CGastrell self-assigned this Apr 19, 2026
@CGastrell CGastrell added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Apr 19, 2026
@CGastrell CGastrell marked this pull request as ready for review April 19, 2026 14:52
@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@CGastrell CGastrell merged commit 191e02e into trunk Apr 19, 2026
87 of 88 checks passed
@CGastrell CGastrell deleted the fix/social-admin-page-restore-footer branch April 19, 2026 15:20
@github-actions github-actions bot removed [Status] Needs Review This PR is ready for review. [Status] In Progress labels Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants