VideoPress: migrate ProgressBar to @wordpress/components#48191
VideoPress: migrate ProgressBar to @wordpress/components#48191
Conversation
Replaces the custom ProgressBar component from @automattic/jetpack-components with the native ProgressBar from @wordpress/components across VideoPress surfaces (admin dashboard storage meter, thumbnail upload progress) and the Jetpack plugin's VideoPress storage meters (performance settings and at-a- glance dashboard). Drops the now-unused progressBarClassName prop from VideoStorageMeter and cleans up the associated CSS overrides. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
| .meter > div { | ||
| height: 12px; | ||
| width: 100%; |
There was a problem hiding this comment.
What's the effect on design, and can we avoid this override?
There was a problem hiding this comment.
Without the height, the default is 1.5px, barely visible. And the width is document here.
| > div { | ||
| height: 3px; | ||
| } |
There was a problem hiding this comment.
Can we avoid this and use component's default height?
Part of #48160
Proposed changes
ProgressBarfrom@automattic/jetpack-componentswith the nativeProgressBarfrom@wordpress/componentson VideoPress-related progress bars:packages/videopress·VideoStorageMeter).packages/videopress·VideoThumbnail).progress(0–1) prop to the WPvalue(0–100) prop, clamped to 100 to match the previous component's internal behavior.progressBarClassNameprop fromVideoStorageMeter(only consumer was the admin page, which only used it for a background-color override that the WP default already provides).Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
VideoPress admin dashboard (packages/videopress)
wp-admin/admin.php?page=jetpack-videopresson a site with a paid VideoPress plan and at least one uploaded video.Jetpack plugin — Performance settings
Jetpack plugin — At-a-Glance dashboard card
Regression checks
VideoStorageMeterandVideoThumbnailstill render.