Search 3.0: add compact search block template#48433
Draft
adamwoodnz wants to merge 1 commit intotrunkfrom
Draft
Conversation
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
Registers a second plugin-origin block template, 'Jetpack Search Results (Compact)', that mirrors the Compact Search pattern (toolbar layout: search input + filter popover + sort popover over a layout="compact" result list). Surfaces alongside the existing sidebar template in the Site Editor's Templates list so site owners can opt into the compact layout without having to edit the default template or hand-build the pattern. The compact slug is intentionally NOT prepended to search_template_hierarchy; only one plugin template should win the /?s=... lookup, and the layout-rich sidebar template remains the default. Refactors get_search_template_content() to take a slug argument and memoize per slug, so register_search_template() can register both templates from the same code path. Co-authored-by: Adam Wood <adamwoodnz@users.noreply.github.com>
fbe59c4 to
dcf77ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes
layout="compact"results list).Search_Blocks::get_search_template_content()to take a slug argument (memoized per slug) soregister_search_template()can register both templates from one code path.The compact slug is intentionally not prepended to
search_template_hierarchy— only one plugin template should win the/?s=…lookup, and the layout-rich sidebar template (jetpack-search) remains the default. Site owners who want the compact layout to take over/?s=…can either edit the resolved search template in the Site Editor or assign the compact template to a page.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
jetpack_search_blocks_enabledtrue and the search-blocks bundle registered./?s=testand confirm the default sidebar layout still resolves (i.e. the compact template did not take over the search hierarchy).jp test php packages/searchSearch_Blocks_Testcases (including the two new ones —test_register_search_template_registers_compact_variantand the updated empty-content / hierarchy assertions) should pass.Test results
Linear Issue: RSM-1944