Merged
Conversation
Code Coverage SummaryCoverage changed in 1 file.
|
816e512 to
7c26d55
Compare
Member
|
Yep 👍 This will mostly just need cursory smoke testing since the components are so similar. I have a bit deeper-going PR to swap usage in Forms: #48407 |
CGastrell
previously approved these changes
May 6, 2026
Contributor
CGastrell
left a comment
There was a problem hiding this comment.
There is disparity with the styles, but it's acceptable. Checked some places to use as sample, didn't test them all. Code looks good ![]()
…_link_instead_of_external_link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The new
@wordpress/use-recommended-componentsESLint rule nudges people to use theLinkcomponent from@wordpress/uiinstead of theExternalLinkcomponent from@wordpress/components.It should be a drop-in replacement with a
openInNewTabprop. Styles are intended to be on par (WordPress/gutenberg#77790).This was mostly straightforward, but a few additional tweaks were required to make CI happy:
BundledWpPkgsTranspileRules()in several projects.ai-chatwas trying to bundlereactas a dependency, so I switched that to a normal<a>: 41a1b2fText→Link→Text→spanwrapper making linters unhappy, so I removed the innerTextand changed the outerTextto use its variant: f54678eRelated product discussion/links
Does this pull request change what data or activity we track or use?
Testing instructions
Along with smoke testing, I'd suggest reviewing code by commit in the following order:
createInterpolateElement(): 6f9fc0b