Activity Log: free-tier follow-ups (inert overlay + branded illustration) by keoshi · Pull Request #48531 · Automattic/jetpack

keoshi · 2026-05-05T15:26:21Z

Proposed changes

Free-tier search overlay (Activity Log): swap the aria-disabled + tabindex="-1" + pointer-events: none triple for a single inert attribute on .dataviews__search. inert natively blocks pointer + keyboard interaction and removes descendants from the a11y tree. Tradeoff: Firefox suppresses title tooltips inside an inert subtree, so the upgrade nudge won't appear there — accepted per the issue.
Refresh the free-tier upsell illustration to the Jetpack-branded SVG (per PR #48418 review). Filename kept so the webpack import resolves untouched.
Lowercase "activity logs" in the upsell title — sentence case to match Jetpack copy conventions.
Wire up the row action — relabelled "Restore backup" so the copy matches what the click does. Instead of being a disabled placeholder, it now opens the Jetpack Cloud Backup restore flow for that rewind point in a new tab (https://cloud.jetpack.com/backup/{calypsoSlug}/restore/{rewindId}). Drops the "Coming soon" tooltip MutationObserver hack the placeholder needed.
- Note: the off-site cloud.jetpack.com link is a stop-gap until the Backup wp-admin port (Backup: New overview UI #48236) lands. Once that ships, every row action here should point at the in-admin Backup page so users stay inside their own wp-admin for the restore flow. Documented in the useActivityActions docblock.

Related product discussion/links

Issue Activity log in wp-admin follow-ups #48527
Original PR Activity Log: default to Table layout and surface disabled toolbar + date picker on free tier #48418
Backup wp-admin port (follow-up that will replace the off-site link): Backup: New overview UI #48236

Does this pull request change what data or activity we track or use?

Adds a new Tracks event: jetpack_activity_log_restore_backup_click (props: rewind_id, activity_name) when the user clicks the "Restore backup" row action.

Testing instructions

Free-tier follow-ups:

Activate Jetpack on a site without an active Backup / VaultPress plan (free tier).
Navigate to Jetpack → Activity Log in wp-admin.
Confirm the new Jetpack-branded illustration appears in the upsell card below the table.
Confirm the title reads "Track every action with activity logs" (lowercase "activity").
In Chrome / Safari, hover the disabled search input/filter cluster — the "Upgrade your plan to use this feature." tooltip should appear. In Firefox, the tooltip is intentionally suppressed (inert subtree limitation).
Try to focus the search input via Tab — focus should skip the cluster.
Try to click into the search input or filter button — clicks should be inert.
The view-config (cog) on the right of the toolbar should still be fully usable.

Restore backup action:
9. On a site with Backup access, navigate to Jetpack → Activity Log.
10. Hover a rewindable activity row (one with a backup icon in Calypso) — the "Restore backup" action should be present and enabled.
11. Click it — a new tab should open at https://cloud.jetpack.com/backup/{your-site-slug}/restore/{rewind-id}.
12. Rows that aren't rewindable should not show the action at all (not even disabled).
13. Confirm a jetpack_activity_log_restore_backup_click Tracks event fires on click.

Per #48527 (and the original PR #48418 review): the `aria-disabled` + `tabindex="-1"` + `pointer-events: none` triple was chosen to keep the `title` upgrade tooltip working in Firefox. We're accepting that tradeoff and going back to the cleaner `inert` attribute, which blocks pointer + keyboard interaction and hides descendants from the a11y tree in one shot. Firefox suppresses `title` tooltips inside an inert subtree, so the upgrade nudge won't appear there — accepted per the issue. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- Swap the upsell callout illustration for the Jetpack-branded version (per #48418 (comment)). Filename kept as `activity-logs-callout-illustration.svg` so the webpack import in `UpsellCallout.tsx` resolves untouched. - Lowercase "activity logs" in the upsell title — sentence case to match Jetpack copy conventions. - Drop the inert-revert changelog from the previous commit; that change has no user-visible behavior shift, so a single user-benefit entry covering the visible refresh suffices. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-05-05T15:27:19Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the try/jetpack-activity-log-followups branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack try/jetpack-activity-log-followups

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-05-05T15:28:14Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2026-05-05T15:36:48Z

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

CGastrell · 2026-05-05T16:23:57Z

This is what I'm seeing on free tier:

CGastrell · 2026-05-05T16:50:50Z

After upgrading:

With a viewport 1261px width I'm seeing a horizontal scrollbar on the dataviews element. Somehow the dataviews container is more narrow than its inner table:

EDIT: found the offending style, padding-right on the last th. But the issue is seen only at this width, maybe just bad luck with my screen, not worth investigation I guess.

On a backup row, I can see the action "Manage backup" but it's disabled/not-clickable, no hint as to why:

The DataViews "Manage backup" row action was a disabled placeholder waiting for a future Backup wp-admin page. Wire it up to open Calypso's Backup restore flow for the row's rewind point in a new tab — `https://wordpress.com/backup/{calypsoSlug}/restore/{rewindId}` — which gives users an actionable path today without waiting on the in-progress port. - `actions.tsx`: read `calypsoSlug` from Initial_State at module load, render the action only when the row is rewindable AND has a `rewindId` AND a slug is available, and on click `window.open` the Calypso URL with `noopener,noreferrer`. Also accept an optional `tracks` handle and emit a `jetpack_activity_log_manage_backup_click` event. - `index.tsx`: pass `tracks` through to `useActivityActions`, and drop the "Coming soon" tooltip MutationObserver effect — the action is no longer disabled so the textContent-matching DOM hack is obsolete. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Jetpack Cloud (cloud.jetpack.com) is the Jetpack-branded analog of the Calypso Backup flow and is what we want users to land on from a Jetpack admin surface. Swap the deep-link host accordingly: `https://cloud.jetpack.com/backup/{calypsoSlug}/restore/{rewindId}`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

keoshi · 2026-05-05T18:34:26Z

Thanks for the review @CGastrell!

With a viewport 1261px width I'm seeing a horizontal scrollbar on the dataviews element.

Can't spot the issue in my testing. Are you seeing a different behavior than this: https://wordpress.github.io/gutenberg/?path=/docs/dataviews-dataviews--docs

On a backup row, I can see the action "Manage backup" but it's disabled/not-clickable, no hint as to why:

Addressing now!

CGastrell · 2026-05-05T18:38:15Z

Can't spot the issue in my testing. Are you seeing a different behavior than this: https://wordpress.github.io/gutenberg/?path=/docs/dataviews-dataviews--docs

Yeah, I realized this is my very specific screen width playing tricks on me. I edited the comment just for papertrail.

- Label "Manage backup" → "Restore backup" — the button opens the Backup restore flow, so the label should describe that. - Tracks event renamed in lockstep: jetpack_activity_log_manage_backup_click → jetpack_activity_log_restore_backup_click. - Document in the hook's docblock that the cloud.jetpack.com deep-link is a stop-gap until the Backup wp-admin port (#48236) lands. After that ships, every row action here should point at the in-admin Backup page instead of cloud.jetpack.com so users stay inside their own wp-admin. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

keoshi · 2026-05-06T14:34:24Z

This is ready for a final review.

dhasilva

LGTM

…ion) (#48531) * Activity Log: revert free-tier search overlay to use inert Per #48527 (and the original PR #48418 review): the `aria-disabled` + `tabindex="-1"` + `pointer-events: none` triple was chosen to keep the `title` upgrade tooltip working in Firefox. We're accepting that tradeoff and going back to the cleaner `inert` attribute, which blocks pointer + keyboard interaction and hides descendants from the a11y tree in one shot. Firefox suppresses `title` tooltips inside an inert subtree, so the upgrade nudge won't appear there — accepted per the issue. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Activity Log: refresh free-tier upsell illustration + lowercase title - Swap the upsell callout illustration for the Jetpack-branded version (per #48418 (comment)). Filename kept as `activity-logs-callout-illustration.svg` so the webpack import in `UpsellCallout.tsx` resolves untouched. - Lowercase "activity logs" in the upsell title — sentence case to match Jetpack copy conventions. - Drop the inert-revert changelog from the previous commit; that change has no user-visible behavior shift, so a single user-benefit entry covering the visible refresh suffices. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Activity Log: deep-link Manage backup action to Calypso restore flow The DataViews "Manage backup" row action was a disabled placeholder waiting for a future Backup wp-admin page. Wire it up to open Calypso's Backup restore flow for the row's rewind point in a new tab — `https://wordpress.com/backup/{calypsoSlug}/restore/{rewindId}` — which gives users an actionable path today without waiting on the in-progress port. - `actions.tsx`: read `calypsoSlug` from Initial_State at module load, render the action only when the row is rewindable AND has a `rewindId` AND a slug is available, and on click `window.open` the Calypso URL with `noopener,noreferrer`. Also accept an optional `tracks` handle and emit a `jetpack_activity_log_manage_backup_click` event. - `index.tsx`: pass `tracks` through to `useActivityActions`, and drop the "Coming soon" tooltip MutationObserver effect — the action is no longer disabled so the textContent-matching DOM hack is obsolete. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Activity Log: point Manage backup at cloud.jetpack.com instead of WPCOM Jetpack Cloud (cloud.jetpack.com) is the Jetpack-branded analog of the Calypso Backup flow and is what we want users to land on from a Jetpack admin surface. Swap the deep-link host accordingly: `https://cloud.jetpack.com/backup/{calypsoSlug}/restore/{rewindId}`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Activity Log: rename action to "Restore backup", flag link as temporary - Label "Manage backup" → "Restore backup" — the button opens the Backup restore flow, so the label should describe that. - Tracks event renamed in lockstep: jetpack_activity_log_manage_backup_click → jetpack_activity_log_restore_backup_click. - Document in the hook's docblock that the cloud.jetpack.com deep-link is a stop-gap until the Backup wp-admin port (#48236) lands. After that ships, every row action here should point at the in-admin Backup page instead of cloud.jetpack.com so users stay inside their own wp-admin. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

keoshi and others added 2 commits May 5, 2026 11:23

keoshi added the [Status] Needs Review This PR is ready for review. label May 5, 2026

keoshi self-assigned this May 5, 2026

github-actions Bot added the [Package] Activity Log label May 5, 2026

keoshi requested review from CGastrell, dhasilva and ilonagl May 5, 2026 15:28

CGastrell added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label May 5, 2026

keoshi and others added 2 commits May 5, 2026 14:12

dhasilva approved these changes May 6, 2026

View reviewed changes

dhasilva merged commit ab3cad2 into trunk May 6, 2026
72 of 73 checks passed

dhasilva deleted the try/jetpack-activity-log-followups branch May 6, 2026 16:16

github-actions Bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] Needs Review This PR is ready for review. labels May 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Activity Log: free-tier follow-ups (inert overlay + branded illustration)#48531

Activity Log: free-tier follow-ups (inert overlay + branded illustration)#48531
dhasilva merged 5 commits intotrunkfrom
try/jetpack-activity-log-followups

keoshi commented May 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 5, 2026 •

edited

Loading

Uh oh!

jp-launch-control Bot commented May 5, 2026 •

edited

Loading

Uh oh!

CGastrell commented May 5, 2026

Uh oh!

CGastrell commented May 5, 2026 •

edited

Loading

Uh oh!

keoshi commented May 5, 2026

Uh oh!

CGastrell commented May 5, 2026

Uh oh!

keoshi commented May 6, 2026

Uh oh!

dhasilva left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

keoshi commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Uh oh!

github-actions Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

CGastrell commented May 5, 2026

Uh oh!

CGastrell commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keoshi commented May 5, 2026

Uh oh!

CGastrell commented May 5, 2026

Uh oh!

keoshi commented May 6, 2026

Uh oh!

dhasilva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

keoshi commented May 5, 2026 •

edited

Loading

github-actions Bot commented May 5, 2026 •

edited

Loading

github-actions Bot commented May 5, 2026 •

edited

Loading

jp-launch-control Bot commented May 5, 2026 •

edited

Loading

CGastrell commented May 5, 2026 •

edited

Loading