Backup: render the modernized dashboard inside a Page chassis#48621
Open
Backup: render the modernized dashboard inside a Page chassis#48621
Conversation
Replace PR 1's `<h1>Backup</h1>` placeholder with `Page` from `@wordpress/admin-ui` — title "VaultPress Backup", subtitle, empty body — so the modernized surface picks up the standard wp-admin chrome. Suppress `admin_notices` and `all_admin_notices` on the modernized page only, mirroring how Jetpack Forms keeps its dashboard from reflowing on top of JITMs and other plugin notices. Legacy Backup admin renders unchanged when the modernization filter is off. PR 2 of eight in umbrella #48582; mirrors the cadence of #48574 (Newsletter page-shell). PR 2.5 (data layer + gates) is next. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
8 tasks
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #48582
Proposed changes
PR 2 of eight in the Backup modernization umbrella. Replaces PR 1's
<h1>Backup</h1>placeholder withPagefrom@wordpress/admin-ui(title "VaultPress Backup", subtitle, empty body) so the modernized surface picks up the standard wp-admin chrome. Suppressesadmin_noticesandall_admin_noticeson the modernized page only, mirroring how Jetpack Forms keeps its dashboard from reflowing on top of JITMs and other plugin notices.No data layer, no gates, no router yet — those land in PR 2.5 (
update/backup-modernization-data-layer). The modernization filter (rsm_jetpack_ui_modernization_backup) still defaults tofalse, so today's Backup admin page renders unchanged for every site.Mirrors the cadence of #48574 (Newsletter page-shell).
Testing instructions
Filter OFF — legacy Backup admin page is unchanged. Visit Jetpack → VaultPress Backup. The page renders today's standalone UI exactly as it did before this PR. Any
admin_notices/all_admin_noticesregistered by core or other plugins still render — this PR doesn't touch them.Filter ON — modernized chassis renders. Add to a mu-plugin:
Reload Jetpack → VaultPress Backup. The page now renders the wp-admin
Pagechassis: a header with the VaultPress Backup title and the Save changes and restore quickly with one-click recovery. subtitle, followed by an empty body. Anyadmin_noticesregistered above (e.g. viaadd_action( 'admin_notices', fn() => print '<div class=\"notice notice-warning\"><p>Test</p></div>' );) are suppressed.Toggle the filter back off. Reload — legacy Backup returns immediately, no cache clears.
Does this pull request change what data or activity we track or use?
No. No new endpoints, payloads, identifiers, Tracks events, or persistent options. The new
Pageshell renders an empty body — there is no data flow yet.Out of scope
References
🤖 Generated with Claude Code