Skip to content

Backup: render the modernized dashboard inside a Page chassis#48621

Open
keoshi wants to merge 1 commit intotrunkfrom
update/backup-modernization-page-shell
Open

Backup: render the modernized dashboard inside a Page chassis#48621
keoshi wants to merge 1 commit intotrunkfrom
update/backup-modernization-page-shell

Conversation

@keoshi
Copy link
Copy Markdown
Contributor

@keoshi keoshi commented May 7, 2026

Refs #48582

Proposed changes

PR 2 of eight in the Backup modernization umbrella. Replaces PR 1's <h1>Backup</h1> placeholder with Page from @wordpress/admin-ui (title "VaultPress Backup", subtitle, empty body) so the modernized surface picks up the standard wp-admin chrome. Suppresses admin_notices and all_admin_notices on the modernized page only, mirroring how Jetpack Forms keeps its dashboard from reflowing on top of JITMs and other plugin notices.

No data layer, no gates, no router yet — those land in PR 2.5 (update/backup-modernization-data-layer). The modernization filter (rsm_jetpack_ui_modernization_backup) still defaults to false, so today's Backup admin page renders unchanged for every site.

Mirrors the cadence of #48574 (Newsletter page-shell).

Testing instructions

  1. Filter OFF — legacy Backup admin page is unchanged. Visit Jetpack → VaultPress Backup. The page renders today's standalone UI exactly as it did before this PR. Any admin_notices / all_admin_notices registered by core or other plugins still render — this PR doesn't touch them.

  2. Filter ON — modernized chassis renders. Add to a mu-plugin:

    add_filter( 'rsm_jetpack_ui_modernization_backup', '__return_true' );

    Reload Jetpack → VaultPress Backup. The page now renders the wp-admin Page chassis: a header with the VaultPress Backup title and the Save changes and restore quickly with one-click recovery. subtitle, followed by an empty body. Any admin_notices registered above (e.g. via add_action( 'admin_notices', fn() => print '<div class=\"notice notice-warning\"><p>Test</p></div>' );) are suppressed.

  3. Toggle the filter back off. Reload — legacy Backup returns immediately, no cache clears.

Does this pull request change what data or activity we track or use?

No. No new endpoints, payloads, identifiers, Tracks events, or persistent options. The new Page shell renders an empty body — there is no data flow yet.

Out of scope

  • No data layer, no gates, no router, no REST bridges (PR 2.5).
  • No Overview, file browser, Download, or Restore screens (PRs 3-6).

References

🤖 Generated with Claude Code

Replace PR 1's `<h1>Backup</h1>` placeholder with `Page` from
`@wordpress/admin-ui` — title "VaultPress Backup", subtitle, empty body —
so the modernized surface picks up the standard wp-admin chrome.
Suppress `admin_notices` and `all_admin_notices` on the modernized page
only, mirroring how Jetpack Forms keeps its dashboard from reflowing on
top of JITMs and other plugin notices. Legacy Backup admin renders
unchanged when the modernization filter is off.

PR 2 of eight in umbrella #48582; mirrors the cadence of #48574
(Newsletter page-shell). PR 2.5 (data layer + gates) is next.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/backup-modernization-page-shell branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/backup-modernization-page-shell
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/backup-modernization-page-shell

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Package] Backup [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 7, 2026
@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/backup/src/class-jetpack-backup.php 53/407 (13.02%) -0.10% 3 ❤️‍🩹

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Backup [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant