Skip to content

Build/mirror test: #48627 (newsletter mu-wpcom)#48655

Open
CGastrell wants to merge 1 commit intotrunkfrom
cg/newsletter-mu-wpcom-build-test
Open

Build/mirror test: #48627 (newsletter mu-wpcom)#48655
CGastrell wants to merge 1 commit intotrunkfrom
cg/newsletter-mu-wpcom-build-test

Conversation

@CGastrell
Copy link
Copy Markdown
Contributor

@CGastrell CGastrell commented May 8, 2026

Build/mirror test for #48627 — that PR is currently in Draft state, so the "Push to mirror repos" job is skipped and the try/newsletter-bootstrap-via-module branch is missing on the Automattic/jetpack-mu-wpcom-plugin and Automattic/wpcomsh mirror repos. That makes it impossible to spin up a Jurassic Ninja site with branches.jetpack-mu-wpcom-plugin=...&branches.wpcomsh=... against the original PR's branch.

This PR is identical in content to #48627 (rebased on current trunk) and is not draft, so the mirror push runs and the matching branch lands on each mirror repo.

Do not merge. This is a build-only test branch — it will be closed once #48627 is marked ready for review (or merged) and the original branch's mirrors are populated.

Testing

JN spawn URL once the mirror branches are live:

https://jurassic.ninja/create?jetpack-beta&branches.jetpack=cg/newsletter-mu-wpcom-build-test&branches.jetpack-mu-wpcom-plugin=cg/newsletter-mu-wpcom-build-test&branches.wpcomsh=cg/newsletter-mu-wpcom-build-test&wp-debug-log

Does this pull request change what data or activity we track or use?

No.

@dhasilva @claude
Newsletter: drop jetpack-newsletter composer dep from mu-wpcom
c3a890c 
mu-wpcom-plugin previously vendored the entire automattic/jetpack-newsletter
package because jetpack-mu-wpcom required it via composer to call
Settings::init() / Reader_Link::init() and to resolve Settings, Reader_Link,
and Urls class names from wpcom-admin-menu, wpcom-admin-bar, and
launchpad-task-definitions. On Atomic sites that run both the standalone
Jetpack plugin and mu-wpcom-plugin, the entire ~8.7 MiB build/ payload of
jetpack-newsletter shipped twice.

Drop the composer require and rely on the Newsletter package being provided
by a sibling plugin's Jetpack autoloader: the standalone Jetpack plugin on
Atomic, or the wpcom platform's bundled Jetpack source on Simple. Every
call site that touches a Newsletter class is now class_exists()-guarded so
mu-wpcom degrades gracefully when no sibling provides the package.

The Settings::init() call in class-jetpack-mu-wpcom.php is preserved (still
needed on Simple where load-jetpack.php does not run); only the dependency
plumbing changed.

Phan can no longer see the Newsletter classes from mu-wpcom's analysis
context (the dep is gone), so each call site uses an FQ string in the
class_exists guard and a @phan-suppress-next-line annotation on the actual
method/constructor call, matching the existing pattern used elsewhere in
mu-wpcom (wpcom-themes/wpcom-theme-tracking.php, custom-css/custom-css.php).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the cg/newsletter-mu-wpcom-build-test branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin cg/newsletter-mu-wpcom-build-test

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

## Testing instructions:

* Go to '..'
*

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 8, 2026
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented May 8, 2026

Code Coverage Summary

Coverage changed in 4 files.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-bar/wpcom-admin-bar.php 121/270 (44.81%) -1.02% 6 💔
projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php 2/357 (0.56%) -0.00% 1 ❤️‍🩹
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php 99/434 (22.81%) -0.05% 1 ❤️‍🩹
projects/packages/jetpack-mu-wpcom/src/features/launchpad/launchpad-task-definitions.php 690/1508 (45.76%) -0.11% 0 💚

Full summary · PHP report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

@CGastrell CGastrell added [Status] In Progress Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR [mu wpcom Feature] Launchpad [mu wpcom Feature] Wpcom Admin Bar [mu wpcom Feature] Wpcom Admin Menu [Package] Jetpack mu wpcom WordPress.com Features [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh [Status] In Progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CGastrell @dhasilva