[RSM] Blog Talks Back: Fix Reader Chat toggle tracking#48724
Merged
Conversation
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
c60ac65 to
e529ae3
Compare
e529ae3 to
7465107
Compare
iamchughmayank
approved these changes
May 12, 2026
Contributor
iamchughmayank
left a comment
There was a problem hiding this comment.
tests well. The event was received in live track
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes
jetpack_reader_chat_toggleevent immediately after the Search settings save request succeeds, using the saved settings response.Related product discussion/links
Does this pull request change what data or activity we track or use?
Yes. This changes when the existing
jetpack_reader_chat_toggleevent is recorded so successful Reader Chat setting changes are tracked more reliably. It does not add a new event or new event properties.Testing instructions
jetpack_reader_chat_toggle