Skip to content

[RSM] Blog Talks Back: Fix Reader Chat toggle tracking#48724

Merged
kat3samsin merged 1 commit into
trunkfrom
fix/reader-chat-toggle-tracking
May 12, 2026
Merged

[RSM] Blog Talks Back: Fix Reader Chat toggle tracking#48724
kat3samsin merged 1 commit into
trunkfrom
fix/reader-chat-toggle-tracking

Conversation

@kat3samsin
Copy link
Copy Markdown
Contributor

@kat3samsin kat3samsin commented May 12, 2026

Fixes #

Proposed changes

  • Record the existing jetpack_reader_chat_toggle event immediately after the Search settings save request succeeds, using the saved settings response.
  • Keep the follow-up settings refresh after tracking, so a stale or failed refetch no longer suppresses the event after a successful save.
  • Move the Reader Chat setting into the Search settings card, directly after the Instant Search setting.
  • Add coverage for enabling Reader Chat, disabling Reader Chat, unchanged values, refetch failure after save, and Reader Chat placement after the Instant Search setting.

Related product discussion/links

  • None.

Does this pull request change what data or activity we track or use?

Yes. This changes when the existing jetpack_reader_chat_toggle event is recorded so successful Reader Chat setting changes are tracked more reliably. It does not add a new event or new event properties.

Testing instructions

  • Install this PR in your sandbox
  • Go to Jetpack > Search
  • Confirm Reader Chat appears after Enable instant search experience (recommended)
  • Toggle Reader Chat On / Off
  • Wait for a few minutes
  • Check live track event jetpack_reader_chat_toggle

@kat3samsin kat3samsin added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Feature] Search For all things related to Search [Status] Needs Tracks Review Added/removed/modified a tracks event. labels May 12, 2026
@kat3samsin kat3samsin self-assigned this May 12, 2026
@kat3samsin kat3samsin added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Feature] Search For all things related to Search [Status] Needs Tracks Review Added/removed/modified a tracks event. labels May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/reader-chat-toggle-tracking branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/reader-chat-toggle-tracking

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Package] Search Contains core Search functionality for Jetpack and Search plugins [Tests] Includes Tests labels May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented May 12, 2026

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/search/src/dashboard/components/module-control/index.jsx 24/38 (63.16%) 63.16% -24 💚

Full summary · PHP report · JS report

@kat3samsin kat3samsin force-pushed the fix/reader-chat-toggle-tracking branch from c60ac65 to e529ae3 Compare May 12, 2026 16:18
@kat3samsin kat3samsin changed the title Search: Fix Reader Chat toggle tracking [RSM] Blog Talks Back: Fix Reader Chat toggle tracking May 12, 2026
@kat3samsin kat3samsin force-pushed the fix/reader-chat-toggle-tracking branch from e529ae3 to 7465107 Compare May 12, 2026 16:43
@iamchughmayank iamchughmayank self-requested a review May 12, 2026 17:54
Copy link
Copy Markdown
Contributor

@iamchughmayank iamchughmayank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests well. The event was received in live track

@kat3samsin kat3samsin merged commit ba6c8a6 into trunk May 12, 2026
76 checks passed
@kat3samsin kat3samsin deleted the fix/reader-chat-toggle-tracking branch May 12, 2026 18:55
@github-actions github-actions Bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] Needs Review This PR is ready for review. labels May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Status] Needs Tracks Review Added/removed/modified a tracks event. [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants