Skip to content

CRM: Address PHP warnings in forms widget and logs#48727

Merged
tbradsha merged 5 commits into
trunkfrom
fix/jetpack/crm_forms_widget_undefined_keys
May 12, 2026
Merged

CRM: Address PHP warnings in forms widget and logs#48727
tbradsha merged 5 commits into
trunkfrom
fix/jetpack/crm_forms_widget_undefined_keys

Conversation

@tbradsha
Copy link
Copy Markdown
Contributor

Proposed changes

This catches the following warnings:

PHP Warning: Undefined array key "id" in /srv/htdocs/wp-content/plugins/zero-bs-crm/includes/ZeroBSCRM.Forms.php on line 109
PHP Warning: Undefined array key "style" in /srv/htdocs/wp-content/plugins/zero-bs-crm/includes/ZeroBSCRM.Forms.php on line 108
PHP Warning: Undefined array key "title" in /srv/htdocs/wp-content/plugins/zero-bs-crm/includes/ZeroBSCRM.Forms.php on line 107
PHP Warning: Undefined property: stdClass::$zbsl_pinned in /srv/htdocs/wp-content/plugins/zero-bs-crm/includes/ZeroBSCRM.DAL3.Obj.Logs.php on line 923

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • Go to '..'

@tbradsha tbradsha self-assigned this May 12, 2026
@tbradsha tbradsha added the [Status] Needs Review This PR is ready for review. label May 12, 2026
@github-actions github-actions Bot added the [Plugin] CRM Issues about the Jetpack CRM plugin label May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented May 12, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

@tbradsha tbradsha merged commit 5531460 into trunk May 12, 2026
68 checks passed
@tbradsha tbradsha deleted the fix/jetpack/crm_forms_widget_undefined_keys branch May 12, 2026 19:37
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] CRM Issues about the Jetpack CRM plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant