Search blocks: Add end-user docs for WooCommerce filter blocks#48757
Search blocks: Add end-user docs for WooCommerce filter blocks#48757kangzj wants to merge 6 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
This comment has been minimized.
This comment has been minimized.
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
🤖 Review-cycle summary —
|
| Source | Comment | Resolution |
|---|---|---|
@claude (bot) |
#4435993130 — Six cross-links in filters-product/README.md point to READMEs that don't exist on trunk yet (Filters, Post Type Scope, Clear Filters, Active Filters, Checkbox Filter, Filter by Date). |
Converted those six references to plain bold text in 9680c40b546. The five links to WC READMEs added in this PR remain as working markdown links. Re-link in a follow-up once the sibling docs land. |
@claude (bot) |
#4435993130 — flavours should be flavors (US-primary codebase). |
Fixed filter-wc-price/README.md L3 in 9680c40b546. Also caught three other UK spellings the bot missed: recognisable → recognizable (price/L82), Customise → Customize (rating/L41), favour → favor (rating/L57). |
@claude (bot) |
#4435993130 — Pa Material example may confuse authors. |
Changed the Label setting example in filter-wc-attribute/README.md L35 from "Pa Material" → "Made from" to "Material" → "Made from" in 9680c40b546. |
@claude (bot) |
#4436050360 / #4436051936 — Re-review verdict: all three issues correctly resolved; no remaining issues. | Endorsement received; no further action needed. |
Unaddressed (flagged for owner): None.
CI: all required checks passing (21 pass, 10 skipping; 0 fail, 0 pending).
Add per-block README documentation, written from the end-user perspective, for the five WooCommerce-only Search blocks: - filter-wc-attribute - filter-wc-price (inputs + slider variations) - filter-wc-rating - filter-wc-stock-status - filters-product (container) Each README covers when to use the block, available settings, and tips, with editor preview, settings panel, and (where applicable) front-end screenshots captured on a local Jetpack docker dev env.
…normalize US English - filters-product/README.md: convert six cross-links pointing to READMEs that don't exist in trunk (Filters, Post Type Scope, Clear Filters, Active Filters, Checkbox Filter, Filter by Date) into plain bold text so they don't render as dead links. - filter-wc-attribute/README.md: change 'Pa Material' example to 'Material' for the Label setting, which matches how site authors actually see WooCommerce attribute names. - filter-wc-price/README.md: 'flavours' → 'flavors', 'recognisable' → 'recognizable'. - filter-wc-rating/README.md: 'Customise' → 'Customize', 'favour' → 'favor'.
… blocks Add a hub document — projects/packages/search/src/search-blocks/blocks/WOOCOMMERCE.md — that documents every WooCommerce feature in the Search blocks from an end-user perspective. The hub serves as the single entry point: it indexes the five WC-only block READMEs added earlier in this branch, and adds first-class coverage of the WC-related options that live on shared (non-WC-only) blocks: - Checkbox Filter: Product Category, Product Tag, and Product Brand variations. - Results List: the Product (for WooCommerce stores) result format. - Sort By: the Rating, Price: low to high, and Price: high to low sort orders. - Active Filters: the price-range chip (with bound-dependent label format). Each shared-block section is illustrated with editor / inspector / front-end screenshots captured on a local docker dev env. The five existing WC-only READMEs now carry a See also footer pointing at the hub doc.
e744504 to
3bde3f2
Compare
|
@claude please review the follow-up commit covering WooCommerce features on shared blocks (filter-checkbox variations, results-list Product layout, results-sort Price/Rating orders, active-filters price chip) and the new WOOCOMMERCE.md hub doc. |
|
Claude finished @kangzj's task in 2m 19s —— View job Review of follow-up commit — WC features on shared blocks + WOOCOMMERCE.md hub doc
Overall this is a strong, well-organized hub doc. The four shared-block sections (Checkbox Filter variations, Results List Product layout, Sort By, Active Filters) are exactly the right scope — concise, end-user-framed, and complementary to the per-block READMEs. The "Putting it together" summary at the end is a nice touch. One factual error in the inserter section, a few cosmetic nits, and a couple of suggestions below. IssuesFactual error —
|
- Correct factual error on line 16: without WooCommerce, the whole product-filter cluster disappears from the inserter — only the base Checkbox Filter remains. The previous text incorrectly listed 'Filter by Rating' as still available; filter-wc-rating is WC-only and does not appear without WooCommerce. - Align the WooCommerce-only blocks table separator widths for consistency with the other tables in the hub doc. - Link Filter by Price / Filter by Rating / Filter by Stock Status in the Checkbox Filter tips, mirroring the cross-link pattern used elsewhere in the file. - Collapse the double blank line before each See also footer in the five WooCommerce README files.
|
Thanks for the follow-up review @claude — addressed in 5d49399:
|
|
Claude finished @kangzj's task in 1m 6s —— View job Re-review of addressed items — commit
|
…ation entries Refactor the Checkbox Filter section in WOOCOMMERCE.md so Product Category, Product Tag, and Product Brand are each treated as their own block-level entry — separate when-to-use, separate editor preview, separate tips — rather than folded into a single combined section. From a site author's perspective these appear as distinct cards in the inserter and warrant individual documentation. A new 'Shared settings inspector' subsection covers the inspector controls once for all three variations (since they share the same parent block's inspector), with a settings table so the per-variation entries stay focused on use and intent. Add two new editor-preview screenshots: filter-checkbox-product-tag.png and filter-checkbox-product-brand.png.
|
Claude finished @kangzj's task in 1m 50s —— View job Re-review of follow-up commits
|
…prereqs The WOOCOMMERCE.md Product Brand prerequisite step and filter-wc-attribute/README.md's attribute setup step both used 'WooCommerce → Products → Brands' / '→ Attributes', which implies a three-level nested nav that doesn't exist. The Products menu (with its Brands and Attributes submenus) is a top-level WordPress admin menu, not a child of the WooCommerce menu. Corrected both to 'Products → Brands' and 'Products → Attributes' so the instruction matches what authors will actually see in the sidebar.
|
Thanks @claude — fixed the admin-path error in e56371c.
The PHP 8.2 CI failure on the previous push was an infra flake ( |
|
@claude please re-review. |
|
Claude finished @kangzj's task in 40s —— View job Re-review of commit
|
|
Claude finished @kangzj's task in 1m 0s —— View job Re-review of commit
|
Fixes #
Proposed changes
filter-wc-attribute— Filter by Product Attributefilter-wc-price— Filter by Price (inputs + slider variations)filter-wc-rating— Filter by Ratingfilter-wc-stock-status— Filter by Stock Statusfilters-product— Product Filters (container)src/search-blocks/blocks/WOOCOMMERCE.md— a hub doc that indexes the five WC-only blocks above and documents every WooCommerce-related option that lives on shared (non-WC-only) Search blocks:src/search-blocks/blocks/.docs-assets/.Related product discussion/links
Does this pull request change what data or activity we track or use?
No — docs and screenshot assets only. No tracking or runtime changes.
Testing instructions
This PR is documentation only — no functional code changes — so testing is a documentation review rather than a build/run cycle.
projects/packages/search/src/search-blocks/blocks/WOOCOMMERCE.md(the hub)projects/packages/search/src/search-blocks/blocks/filter-wc-attribute/README.mdprojects/packages/search/src/search-blocks/blocks/filter-wc-price/README.mdprojects/packages/search/src/search-blocks/blocks/filter-wc-rating/README.mdprojects/packages/search/src/search-blocks/blocks/filter-wc-stock-status/README.mdprojects/packages/search/src/search-blocks/blocks/filters-product/README.mdprojects/packages/search/changelog/rsm-2807-wc-search-block-docscovers both the per-block READMEs and the hub doc.