Performance settings: simplify Search section to a dashboard link#48773
Draft
kangzj wants to merge 2 commits into
Draft
Performance settings: simplify Search section to a dashboard link#48773kangzj wants to merge 2 commits into
kangzj wants to merge 2 commits into
Conversation
The Search section in Jetpack → Settings → Performance duplicated the Classic/Instant Search toggles already shown on the Search dashboard, and offered no entry point to the new embedded search experience. Replace the toggles + widget/customize cards with a short intro that acknowledges the available experiences (embedded results page, overlay, theme search) and a single CTA linking to the Search dashboard, where the full experience picker lives. The SettingsCard upsell banner for sites without a Search plan continues to render automatically. SEARCH-161
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
github-actions
Bot
added
[Plugin] Jetpack
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
github-actions
Bot
added
the
[Status] Needs Author Reply
The Jetpack plugin's changelogger config only accepts major, enhancement, compat, bugfix, or other. CI flagged "changed" as invalid; switch to enhancement, which fits the simplification best.
Code Coverage SummaryCoverage changed in 5 files.
|
github-actions
Bot
removed
[Status] Needs Author Reply
github-actions
Bot
added
[Status] In Progress
[Status] Needs Author Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SEARCH-161
Proposed changes
admin.php?page=jetpack-search, where the full experience picker (Embedded / Overlay / Theme search / Off) already lives.SettingsCardupsell banner for sites without a Search plan continues to render automatically — that path was driven byfeature={ FEATURE_SEARCH_JETPACK }, not by anything removed here.The previous UI predates the new feature selector and had no entry point for the embedded experience. Two surfaces showing similar-but-not-identical toggles was confusing, so this PR collapses Performance down to the description + link agreed on in the issue thread.
Before / after
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
pnpm jetpack build plugins/jetpack).wp-admin → Jetpack → Settings → Performance.admin.php?page=jetpack-search.pnpm test-gui -- _inc/client/performance/test/component.js.Checklist