Skip to content

Connection: show JP logo at users list#48951

Merged
simison merged 1 commit into
trunkfrom
update/users-connected-jp-logo
May 19, 2026
Merged

Connection: show JP logo at users list#48951
simison merged 1 commit into
trunkfrom
update/users-connected-jp-logo

Conversation

@simison
Copy link
Copy Markdown
Member

@simison simison commented May 19, 2026

Proposed changes

  • Show the Jetpack icon beside the Connected label in the WordPress.com account column on the Users screen. Just adds a bit of clarity what/which plugin connection we're talking about here.

Before

Screenshot 2026-05-19 at 11 57 03

After

Screenshot 2026-05-19 at 12 19 52

Tooltips just for reference (no changes in this PR):

image image

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • Go to 'Users'
  • See Jetpack connecter user now with logo

@simison simison requested review from DevinWalker and keoshi May 19, 2026 09:23
@simison simison requested a review from a team as a code owner May 19, 2026 09:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/users-connected-jp-logo branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/users-connected-jp-logo
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/users-connected-jp-logo

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 19, 2026
@simison simison added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 19, 2026
Copy link
Copy Markdown
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice touch.

@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented May 19, 2026

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/connection/src/class-users-connection-admin.php 1/95 (1.05%) -0.14% 11 💔

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@simison simison added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label May 19, 2026
@simison
Copy link
Copy Markdown
Member Author

simison commented May 19, 2026

WP Cloud Unit Testing for WPCOMSH / Run PHPUnit on the WP Cloud test site

This one failing in CI is a known ongoing issue. Unrelated.

@simison simison merged commit af36a06 into trunk May 19, 2026
100 of 102 checks passed
@simison simison deleted the update/users-connected-jp-logo branch May 19, 2026 10:18
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label May 19, 2026
Copilot AI pushed a commit that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Package] Connection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants