General: Update minimum WordPress version to 6.9#49021
Conversation
This updates the minimum WordPress version for our plugins (other than CRM, Premium Analytics, and VaultPress) to 6.9, as we support only the current and previous versions. This is considered a "major change". This also cleans up various obsolete Phan suppressions, a few tests, and some Phan config that was getting confused by recent additions of `wp-build`. See #46801 for the previous bump, for comparison.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Backup plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Search plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Social plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Starter Plugin plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Videopress plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Inspect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Automattic For agencies client plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Classic Theme helper plugin plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Paypal Payment buttons plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcloud Sso plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Premium Analytics plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
| array( | ||
| '+stubs' => array( 'woocommerce-internal' ), | ||
| 'exclude_file_regex' => array( | ||
| 'build/', |
There was a problem hiding this comment.
Thanks! I had this on my list to update four projects.
There was a problem hiding this comment.
Looks like five now with premium-analytics. But you got them. 🎉
tbradsha
left a comment
There was a problem hiding this comment.
Looks good. Two questions, but no blockers.
- Why not bump the
premium-analyticsplugin? - We could perhaps remove this comment:
jetpack/projects/packages/search/src/search-blocks/class-search-blocks.php
Lines 841 to 843 in 1f70831
As for that second point, I'm curious what the policy is for package support on old versions. For example, if one removed the guard in the latest version of the package, and I have an old WP and old Jetpack Search plugin, would things then break when latest Jetpack is installed (perhaps manually because WP.org would restrict it) because the autoloader would select the newest version of the package?
It's currently on 6.6 rather than 6.8 (and its "tested up to" is only 6.8). We should figure out who owns that and see what they want to do. Which should probably be a separate PR anyway, if only to bring it into line with the rest of the monorepo going forward.
🤷.
I can't say I'm too worried about that scenario, since they're already breaking their site by installing the newer Jetpack. I don't know of any official written-down policy, generally I just assume "one previous" like for the plugins since that's all we actually test against. |
Looking back at #48087, which was the only PR touching it, I think the answer is "no one cares, this exists only for testing in the first place". Given that, I'll go ahead and bump it too. |
Proposed changes
This updates the minimum WordPress version for our plugins (other than CRM and VaultPress) to 6.9, as we support only the current and previous versions. This is considered a "major change".
This also cleans up various obsolete Phan suppressions, a few tests, and some Phan config that was getting confused by recent additions of
wp-build.See #46801 for the previous bump, for comparison.
Related product discussion/links
None, apparently. 🙁
Does this pull request change what data or activity we track or use?
No
Testing instructions