Hello Dolly: retire legacy per-page #dolly rules (#49285 Phase 4)

[CGastrell]

Part of #49285 (Phase 4 — the final phase).

Proposed changes

Retire the two legacy per-page Hello Dolly rules now that WPDS design tokens load on every Jetpack admin page (build-time for the legacy _inc pages via #48750, runtime for modernized pages via #49345), so the single normalized central rule governs Dolly consistently.

• Remove .wp-admin #dolly — _inc/client/scss/shared/admin-static.scss (static #87a6bc).
• Remove .jetpack-pagestyles #dolly — _inc/client/scss/shared/_main.scss (SCSS $gray ≈ #a1a1a1).

The central :global(.jetpack-admin-page #dolly) rule (token-based, resolves to #707070) is left as the sole rule. The three rules all had equal specificity (class + id), so the legacy two only competed with the central one by load order. Their position: relative used all-zero offsets (top/right/left: 0) — visually identical to static — so removing them causes no layout shift; the central rule's @media (max-width: 659px) { display: none } already covers the <660px breakpoint the legacy rules handled.

Net visible effect: Hello Dolly converges to #707070 on the pages where a legacy rule previously won (Settings/Dashboard/Debugger), with hello.php's default padding (5px 10px vs the legacy 10px — Dolly is ~10px shorter). Intended per the tracking issue.

Preserved (untouched): My Jetpack's p#dolly { display: none } (its own package CSS) and JITM adjacency.

Related product discussion/links

• Issue: Normalize Hello Dolly across Jetpack admin pages + consistent WPDS token loading #49285
• Phase 2 companions (merged): Jetpack: resolve WPDS design tokens in legacy dashboard CSS #48750 (build-time tokens, legacy _inc), Admin UI: ship shared WPDS design-tokens stylesheet on Jetpack admin pages #49345 (runtime tokens stylesheet)

Does this pull request change what data or activity we track or use?

No.

Testing instructions

On a Jetpack admin page where Hello Dolly is active (the hello.php plugin enabled):

1. Go to Jetpack → Dashboard (and Settings, Debugger).
2. Inspect the <p id="dolly"> strip at the top of the content area.
3. Its color should be #707070 (WPDS --wpds-color-fg-content-neutral-weak), governed solely by .jetpack-admin-page #dolly — the .wp-admin #dolly and .jetpack-pagestyles #dolly rules should no longer exist in the loaded CSS.
4. Confirm no positioning regression: Dolly remains top-right-aligned in normal flow, not overlapping the page title.
5. My Jetpack: Hello Dolly remains hidden (display: none).

Verified locally (dev site, with #48750 + #49345 on trunk): Dashboard #dolly computed color: rgb(112, 112, 112) (#707070), position: static, same top/left/width as before — no layout regression; only the two legacy rules removed, central rule governs.

Screenshots

Before (legacy rule wins → #87a6bc):

After (central token rule → #707070):

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the change/retire-legacy-dolly-rules branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack change/retire-legacy-dolly-rules

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

---

Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[dhasilva]

LGTM.
The message is visible on My Jetpack, but it also is visible on trunk, so not a regression.