Social: remove unused store selector and utility functions#49528
Open
gmjuhasz wants to merge 1 commit into
Open
Social: remove unused store selector and utility functions#49528gmjuhasz wants to merge 1 commit into
gmjuhasz wants to merge 1 commit into
Conversation
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 3 files.
|
1664d62 to
9e3f40c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes
isSavingScheduledShareselector from the social store. It was registered on the store but never called anywhere.getA11yLabelForConnectionPreviewutility fromutils/misc.ts. Its siblinggetA11yLabelForConnectionToggleis still used and unchanged.createActiveConnectionshelper fromutils/test-utils.js, which no test imports.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
git grep -E "isSavingScheduledShare|getA11yLabelForConnectionPreview|createActiveConnections"should return nothing.cd projects/packages/publicize && pnpm run test— all tests should pass.pnpm run typecheckin the same directory — should pass with no errors.