Skip to content

Social: remove unused store selector and utility functions#49528

Open
gmjuhasz wants to merge 1 commit into
trunkfrom
remove/publicize-unused-selectors-utils
Open

Social: remove unused store selector and utility functions#49528
gmjuhasz wants to merge 1 commit into
trunkfrom
remove/publicize-unused-selectors-utils

Conversation

@gmjuhasz

Copy link
Copy Markdown
Contributor

Fixes #

Proposed changes

  • Remove the unused isSavingScheduledShare selector from the social store. It was registered on the store but never called anywhere.
  • Remove the unused getA11yLabelForConnectionPreview utility from utils/misc.ts. Its sibling getA11yLabelForConnectionToggle is still used and unchanged.
  • Remove the unused createActiveConnections helper from utils/test-utils.js, which no test imports.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Verify the removed functions are not referenced anywhere: git grep -E "isSavingScheduledShare|getA11yLabelForConnectionPreview|createActiveConnections" should return nothing.
  • Run the package tests: cd projects/packages/publicize && pnpm run test — all tests should pass.
  • Run the typecheck: pnpm run typecheck in the same directory — should pass with no errors.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the remove/publicize-unused-selectors-utils branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack remove/publicize-unused-selectors-utils

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize labels Jun 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control

jp-launch-control Bot commented Jun 10, 2026

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/packages/publicize/_inc/utils/misc.ts 2/3 (66.67%) 16.67% -1 💚
projects/packages/publicize/_inc/social-store/selectors/scheduled-shares.ts 3/12 (25.00%) -1.67% -2 💚
projects/packages/publicize/_inc/utils/test-utils.js 34/34 (100.00%) 5.56% -2 💚

Full summary · PHP report · JS report

@gmjuhasz gmjuhasz force-pushed the remove/publicize-unused-selectors-utils branch from 1664d62 to 9e3f40c Compare June 22, 2026 08:38
@gmjuhasz gmjuhasz requested a review from manzoorwanijk June 22, 2026 08:38
@gmjuhasz gmjuhasz marked this pull request as ready for review June 22, 2026 08:38

@manzoorwanijk manzoorwanijk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants