Premium Analytics: port the Bookings revenue by customer type widget#49703
Draft
nerrad wants to merge 1 commit into
Draft
Premium Analytics: port the Bookings revenue by customer type widget#49703nerrad wants to merge 1 commit into
nerrad wants to merge 1 commit into
Conversation
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
7ff7f71 to
22e10a7
Compare
1c06d70 to
562cd7b
Compare
1299eba to
456f455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: WOOA7S-1465
Proposed changes
jpa/bookings-revenue-by-customer-typewidget and renders the shared bookings revenue by customer type widget insideWidgetRootusing dashboard-level report params.WidgetDashboardWithWidgethelper.trunk; the shared dashboard/package scaffolding is already provided by trunk, so this PR diff is limited to the widget port.Storybook screenshot
Captured from the local Storybook widget dashboard story.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Using pnpm 11.5.2:
pnpm install --frozen-lockfilepnpm --filter @automattic/charts buildpnpm --filter @automattic/number-formatters buildpnpm --filter @automattic/jetpack-wp-build-polyfills buildpnpm --filter @automattic/jetpack-premium-analytics typecheckpnpm --filter @automattic/jetpack-premium-analytics buildpnpm --filter @automattic/jetpack-storybook storybook:buildpackages-premium-analytics-widgets-bookingsrevenuebycustomertype--widget-dashboard-with-widget: title rendered, chart labelsReturningandNewrendered, and noNaN/undefinedtext. The only console error was the existing Storybookcore/noticesduplicate-registration message.