Premium Analytics: port the Gross sales over time widget#49709
Draft
nerrad wants to merge 3 commits into
Draft
Conversation
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
7ff7f71 to
22e10a7
Compare
95d36de to
3f56150
Compare
3f56150 to
0200c92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: WOOA7S-1470
Proposed changes
jpa/gross-sales-over-timewidget and renders the shared order metric widget insideWidgetRootfororders_value_grossusing dashboard-level report params.WidgetRootusing the current trunk widget render prop pattern.DefaultandWithComparisonstories plus a separateWidgetDashboardWithWidgetdashboard story with dashboard sizing and date preset controls.Storybook screenshot
Captured from the local Storybook widget dashboard story.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
pnpm --filter @automattic/jetpack-premium-analytics typecheckpnpm --filter @automattic/jetpack-premium-analytics buildpnpm --filter @automattic/jetpack-storybook storybook:buildpackages-premium-analytics-widgets-grosssalesovertime--widget-dashboard-with-widget: verified the dashboard title, widget title, currency value, chart SVGs, and noNaNorundefinedtext.