Premium Analytics: port the Sales by coupon widget#49718
Draft
nerrad wants to merge 3 commits into
Draft
Conversation
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
7ff7f71 to
22e10a7
Compare
5921383 to
2b6d367
Compare
a23f6c9 to
bc5d7fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: WOOA7S-1477
Proposed changes
jpa/sales-by-couponwidget and renders the shared sales by coupon widget insideWidgetRootusing dashboard-level report params.trunk; the shared dashboard/package scaffolding is already present there, so this diff is limited to the Sales by coupon widget port.Storybook screenshot
Captured from the local Storybook widget dashboard story.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
pnpm install --frozen-lockfilepnpm --filter @automattic/charts buildpnpm --filter @automattic/number-formatters buildpnpm --filter @automattic/jetpack-wp-build-polyfills buildpnpm exec eslint projects/packages/premium-analytics/widgets/sales-by-coupon/render.tsx projects/packages/premium-analytics/widgets/sales-by-coupon/stories/sales-by-coupon-widget.stories.tsx projects/packages/premium-analytics/widgets/sales-by-coupon/widget.ts projects/packages/premium-analytics/widgets/stories/widget-dashboard-with-widget.tsx --max-warnings=0pnpm --filter @automattic/jetpack-premium-analytics typecheckpnpm --filter @automattic/jetpack-premium-analytics buildpnpm --dir projects/js-packages/storybook run storybook:buildpackages-premium-analytics-widgets-salesbycoupon--widget-dashboard-with-widgetin a browser smoke test: title rendered, chart SVG rendered, coupon labels rendered, and noNaN/undefinedoutput.