Premium Analytics: port the Sales by UTM source widget#49723
Draft
nerrad wants to merge 2 commits into
Draft
Conversation
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
7ff7f71 to
22e10a7
Compare
f20b2f2 to
a7dc5a1
Compare
cc98ab1 to
f1272fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: WOOA7S-1481
Proposed changes
jpa/sales-by-utm-sourcewidget and renders the shared sales by UTM widget insideWidgetRootfor the source view using dashboard-level report params.WidgetRootso report failures surface through the host error UI.Storybook screenshot
Captured from the local Storybook widget dashboard story.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
/Users/dethier/Library/pnpm/pnpm install --frozen-lockfile/Users/dethier/Library/pnpm/pnpm --filter @automattic/charts build/Users/dethier/Library/pnpm/pnpm --filter @automattic/number-formatters build/Users/dethier/Library/pnpm/pnpm --filter @automattic/jetpack-wp-build-polyfills build/Users/dethier/Library/pnpm/pnpm --filter @automattic/jetpack-premium-analytics typecheck/Users/dethier/Library/pnpm/pnpm --filter @automattic/jetpack-premium-analytics build/Users/dethier/Library/pnpm/pnpm --filter @automattic/jetpack-storybook storybook:buildpackages-premium-analytics-widgets-salesbyutmsource--widget-dashboard-with-widget: verified the widget title/region, mocked source rows (google,facebook,instagram), values, comparison legend, SVG chart rendering, and noNaN/undefined. The only console error observed was the known baseline duplicatecore/noticesregistration.