SEO: remove the rsm_jetpack_seo feature flag (JETPACK-1702)#49835
SEO: remove the rsm_jetpack_seo feature flag (JETPACK-1702)#49835angelablake wants to merge 2 commits into
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so: Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 2 files.
|
9b4c05e to
7980031
Compare
The Jetpack SEO product is built and merged, so retire the launch flag and let the install-cohort visibility rules gate the surface: - Initializer::init() no longer bails on the flag; the cohort gate (is_seo_surface_visible: fresh installs + WordPress.com visible, existing self-hosted opt in) is now the only gate. - is_optin_available() simplifies to `! is_seo_surface_visible()`. - The legacy Traffic plugin-search hint keys off the SEO dashboard's per-site availability (Initializer::is_seo_surface_visible) instead of the flag, so its CTAs never point to an unregistered page. - Drop the now-unused FEATURE_FILTER constant and the flag-driven tests; update the My Jetpack opt-in card docs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
7980031 to
809421f
Compare
Proposed changes
Retire the
rsm_jetpack_seolaunch flag now that the Jetpack SEO product is built and merged. With the flag gone, the SEO surface is governed solely by the install-cohort visibility rules that already shipped in PR #5c (#49672) / #5b (#49697):Initializer::init()no longer bails on the feature flag. The discoverability cohort gate (is_seo_surface_visible()) is now the only gate: fresh installs and all WordPress.com sites (Simple + Atomic) are visible; existing self-hosted installs stay hidden until they opt in (legacy Traffic page / My Jetpack).Initializer::is_optin_available()simplifies to! is_seo_surface_visible()— the opt-in surfaces (Traffic-page banner, My Jetpack card) now show purely on cohort state.modules/plugin-search.php) now keys off the SEO dashboard's per-site availability (Initializer::is_seo_surface_visible(), guarded byclass_exists) instead of the global flag, so its CTAs never point to a page that isn't registered on that site.FEATURE_FILTERconstant and the flag-driven unit tests; refresh the My Jetpack opt-in-card docblock that described the flag.No data-shape changes:
seo.optin_availableandseo.surface_visibleare still injected (now unconditionally rather than flag-gated), so the legacy Traffic page reads them exactly as before.Why
rsm_jetpack_seowas added at the foundation merge to hide the in-progress product. The product is complete and the cohort rollout is in place, so removing the flag is the final pre-launch step (JETPACK-1702). After this lands, the SEO dashboard becomes available per the cohort rules on the next release.Does this pull request change what data or activity we track?
No new tracking. The Tracks work is handled separately (JETPACK-1728).
Testing instructions
On a build of this branch:
admin.php?page=jetpack-seo.Test environments
Screenshots
Screenshots to be added by author.