Premium Analytics: port Stats Clicks widget#50052
Conversation
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Premium Analytics plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
chihsuan
left a comment
There was a problem hiding this comment.
I did not verify the widget in a browser-backed Storybook session locally.
Would you be able to verify? 😅
Two things show up in the rendered widget that are worth fixing first:
- The leaderboard isn't sorted (the 3K
developer.wordpress.org/referencerow renders third.) - The "opens in new tab" arrow is orphaned onto its own line under each label
Also left a few non-blocking notes.
b18a36c to
71fdc63
Compare
71fdc63 to
845c035
Compare
Fixes WOOA7S-1494
Proposed changes
Related product discussion/links
Does this pull request change what data or activity we track or use?
No. This reads existing Jetpack Stats clicks data through the existing Premium Analytics stats data layer.
Testing instructions
pnpm --dir projects/packages/premium-analytics test -- --runTestsByPath widgets/clicks/__tests__/clicks.test.tsx --runInBand.pnpm --dir projects/packages/premium-analytics typecheck.Packages/Premium Analytics/Widgets/Clicks.Default,WithComparison,LoadingState,ErrorState,EmptyState,WithMockRows, andWidgetDashboardWithWidgetstories render as expected.jetpack test js packages/premium-analytics(skips becausepackages/premium-analyticsdoes not define atest-jsscript incomposer.json).