Premium Analytics: keep widget-dashboard story settings drawer on-screen#50070
Open
chihsuan wants to merge 1 commit into
Open
Premium Analytics: keep widget-dashboard story settings drawer on-screen#50070chihsuan wants to merge 1 commit into
chihsuan wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
github-actions
Bot
added
the
[Status] Needs Author Reply
chihsuan
added
[Status] Needs Review
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
github-actions
Bot
added
[Status] Needs Author Reply
5 tasks
chihsuan
added
[Status] Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the shared
WidgetDashboardWithWidgetStorybook story, opening a widget's settings (⚙ gear → drawer) looked broken — the drawer rendered off the visible canvas. The setting itself works (verified live preview + Save); only the drawer was off-screen.Drawerisposition: fixed; right: 0, portaled to<body>, so it anchors to the iframe viewport. The story wrapped the dashboard in onewidth: dashboardWidth; max-width: 100%div, so at the1644pxdesktop preset the grid overflows the document horizontally whenever the preview canvas is narrower — pushing the drawer past the visible pane.width: 100%; overflow-x: auto+ innerwidth: dashboardWidth) so the body never overflows and the drawer stays on-screen; the wide layout is still reachable by scrolling.widgets/stories/widget-dashboard-with-widget.tsxonly.Storybook-harness fix; real wp-admin renders full-width, so product behavior is unchanged.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
storybook:dev, port 50240).Screen.Recording.2026-06-30.at.3.44.58.PM.mov