Agents Manager: skip the docked-sidebar pre-render on the Site Editor navigation view

[wellyshen]

Part of AI-1044

Proposed changes

• Add Agents_Manager::is_site_editor_navigation() — true on site-editor.php without ?canvas=edit.
• Skip pre-rendering the docked sidebar shell on the navigation view (Sidebar_Open_Preservation delegates to the shared check), so no reserved sidebar space flashes before the app boots — only the editing canvas (?canvas=edit) can dock the chat.

The admin-bar entry points (the Ask AI button and the Help "?" menu) stay registered on the navigation view: the Site Editor toggles the canvas client-side with no reload, so they must stay in the DOM the whole session. The frontend hides them on the navigation view instead (see the paired wp-calypso PR).

Related product discussion/links

• AI-1044

Does this pull request change what data or activity we track or use?

No.

Testing instructions

• Refer to Agents Manager: hide chat and its entry buttons on the Site Editor navigation view wp-calypso#112164

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/agents-manager-hide-chat-on-site-editor-dashboard branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/agents-manager-hide-chat-on-site-editor-dashboard

bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/agents-manager-hide-chat-on-site-editor-dashboard

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/agents-manager/src/class-agents-manager.php	265/394 (67.26%)	-0.69%	4 💔
projects/packages/agents-manager/src/class-sidebar-open-preservation.php	32/36 (88.89%)	0.65%	0 💚

Full summary · PHP report · JS report

_{Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .}

[Copilot]

Pull request overview

This PR refines where Agents Manager’s editor chat entry points and docked-sidebar shell are rendered by distinguishing the Site Editor dashboard (site-editor.php without ?canvas=edit) from the editing canvas.

Changes:

• Add an Agents_Manager::is_site_editor_dashboard() check and use it to skip registering the omnibar Ask AI button and Help “?” menu on the Site Editor dashboard.
• Prevent Sidebar_Open_Preservation from pre-rendering the docked shell on the Site Editor dashboard (avoids reserved-space flash).
• Add/adjust PHPUnit coverage for both the dashboard vs canvas behaviors.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
projects/packages/agents-manager/tests/php/Sidebar_Open_Preservation_Test.php	Updates/extends tests to ensure the docked shell is only pre-rendered in the Site Editor canvas (?canvas=edit) and not on the dashboard.
projects/packages/agents-manager/tests/php/Agents_Manager_Test.php	Adds tests validating omnibar entry points are registered in the Site Editor canvas but not on the dashboard.
projects/packages/agents-manager/src/class-sidebar-open-preservation.php	Skips docked-shell pre-rendering on the Site Editor dashboard via the shared check.
projects/packages/agents-manager/src/class-agents-manager.php	Adds is_site_editor_dashboard() and uses it to avoid omnibar entry point registration on the dashboard view.
projects/packages/agents-manager/changelog/fix-agents-manager-site-editor-dashboard-no-dock-shell	Adds a patch-level fixed changelog entry for the behavior change.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.