Skip to content

Fix Jetpack wp-admin transition flash#50128

Open
DevinWalker wants to merge 6 commits into
trunkfrom
codex/fix-jetpack-admin-transition-flash
Open

Fix Jetpack wp-admin transition flash#50128
DevinWalker wants to merge 6 commits into
trunkfrom
codex/fix-jetpack-admin-transition-flash

Conversation

@DevinWalker

@DevinWalker DevinWalker commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Fixes JETPACK-1801

Proposed changes

  • Updates the shared Jetpack wp-build admin-page layout so @wordpress/boot keeps a light loading canvas instead of inheriting the active wp-admin color scheme's dark canvas before the stage is ready.
  • Resets boot's default loaded-surface margin and paints that surface with the dark wp-admin chrome color behind the rounded white content stage.
  • Masks the boot stage with its rounded radius so child admin-ui surfaces cannot paint square white corners over the dark surface.
  • Opts the boot stage/inspector out of named View Transitions on Jetpack wp-build admin pages to prevent old/new route content from overlapping, fading, and shrinking during in-app route changes.
  • Adds a base-styles changelog entry.

This intentionally keeps the PR scoped to the wp-build content layer. Full document navigation between Jetpack submenu pages can still reload the WordPress admin shell; that broader Phase II issue is tracked separately in JETPACK-1802.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • In a Jetpack wp-admin environment using the modern wp-build pages, open Forms at the Responses route.
  • Click between the Forms and Responses tabs.
  • Verify the page no longer flashes a full dark canvas before the rounded white boot stage is ready.
  • Verify the content frame still has visible rounded corners over the dark wp-admin chrome color, without extra right or bottom gaps.
  • Verify the route change does not show old/new content overlapping, fading, or shrinking.
  • Note that this PR does not attempt to keep the wp-admin top bar/sidebar persistent across full admin.php?page=... document navigations; that is the Phase II follow-up.
  • Local checks run:
    • git diff --check
    • node -e "..." source probe confirming the light boot loading canvas, flush dark loaded boot surface, rounded stage mask, and view-transition overrides are present.
    • Manual Chrome check on a Jurassic Tube slot: in-app Forms tab navigation kept the wp-admin shell present; the boot loading canvas is light, the loaded boot surface is rgb(30, 30, 30), the stage has border-radius: 8px, boot/stage offsets are 0 on all sides, and all four radius cutouts resolve to the dark loaded surface instead of the white child surface.

Note: the local pre-commit hook could not run because this environment has Node 24.14.0 while the repo currently requires ^24.15.0. The commit was created with --no-verify after the checks above passed.

@DevinWalker DevinWalker added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. labels Jul 1, 2026
@DevinWalker DevinWalker self-assigned this Jul 1, 2026
@DevinWalker DevinWalker added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. labels Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the codex/fix-jetpack-admin-transition-flash branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack codex/fix-jetpack-admin-transition-flash
bin/jetpack-downloader test jetpack-mu-wpcom-plugin codex/fix-jetpack-admin-transition-flash

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control

jp-launch-control Bot commented Jul 1, 2026

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@DevinWalker DevinWalker marked this pull request as ready for review July 1, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [JS Package] Base Styles RNA [Status] In Progress [Status] Needs Review This PR is ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant