Skip to content

WOOA7S-1509: Port Stats Most popular day widget#50152

Draft
kangzj wants to merge 2 commits into
trunkfrom
add/wooa7s-1509-most-popular-day
Draft

WOOA7S-1509: Port Stats Most popular day widget#50152
kangzj wants to merge 2 commits into
trunkfrom
add/wooa7s-1509-most-popular-day

Conversation

@kangzj

@kangzj kangzj commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Fixes WOOA7S-1509

Proposed changes

  • Port the Jetpack Stats Insights "Most popular day" highlight into a registered Premium Analytics widget (jpa/most-popular-day).
  • The widget shows the day of the week that draws the highest share of views (e.g. "Thursday") together with that share, composing a <Text> label with MetricWithComparison (value only, no comparison) from the widgets toolkit.
  • Data comes from the existing useStatsInsights hook. The insight is site-wide: it has no comparison period and does not depend on the dashboard date range, so WithComparison renders identically to Default.
  • Ships the required widget files (package.json, widget.json, widget.ts, render.tsx, CSS Module) plus the three-story Storybook file. stats/insights is not covered by the central registerReportMocks(), so a story-scoped apiFetch middleware supplies the raw insights payload (the shared mocks are left untouched).

Related product discussion/links

Does this pull request change what data or activity we track or use?

No. It reuses the existing stats/insights proxy endpoint through the established data hook; no new tracking.

Testing instructions

  • Live-dashboard verification pending — handled centrally; Storybook + audit + eslint + build pass locally.
  • Storybook: run the Premium Analytics Storybook and open Packages/Premium Analytics/Widgets/MostPopularDay. Confirm Default, WithComparison, and WidgetDashboardWithWidget render a populated highlight ("Thursday — 45% of views"); WithComparison should look identical to Default.
  • Build/lint: jetpack build packages/premium-analytics --deps, pnpm exec eslint projects/packages/premium-analytics/widgets/most-popular-day, and stylelint on the CSS Module all pass.

Add the Most popular day widget to the Premium Analytics dashboard: the
day of the week that draws the highest share of views, ported from the
Jetpack Stats Insights highlight. Composes a Text label with
MetricWithComparison for the share; the insight has no comparison period
and ignores the dashboard date range.
@jp-launch-control

jp-launch-control Bot commented Jul 2, 2026

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 2, 2026
@kangzj

kangzj commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Live dashboard verification — Most popular day

Rendered on the connected Premium Analytics dashboard (Insights tab, raven env, blog 254382195) with real data and zero console errors.

Most popular day

@kangzj kangzj marked this pull request as ready for review July 2, 2026 07:33
@kangzj kangzj requested review from a team as code owners July 2, 2026 07:33
@kangzj kangzj marked this pull request as draft July 2, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Premium Analytics [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant