WOOA7S-1512: Port Stats All-time total views widget#50157
Draft
kangzj wants to merge 2 commits into
Draft
Conversation
Add the All-time views widget to the Premium Analytics dashboard. It shows the site's lifetime view total from the site stats summary via useStatsSite, rendered as a bare formatted number with MetricWithComparison (no comparison period).
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
github-actions
Bot
added
[Status] In Progress
[Status] Needs Author Reply
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Contributor
Author
Live dashboard verification — All-time total viewsRendered on the connected Premium Analytics dashboard (Insights tab, raven env, blog 254382195) with real data and zero console errors.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WOOA7S-1512
Proposed changes
jpa/all-time-views).widgets/all-time-views/(package.json, widget.json, widget.ts, render.tsx, CSS Module, Storybook story).useStatsSite,data.stats.views) as a bare formatted number viaMetricWithComparison(value only,useMultipliers/decimals: 0) with a caption. The summary has no date range or comparison period, so no trend chart or delta is rendered./proxy/v1.1/statssummary endpoint, the story registers a story-scopedapiFetchmiddleware (registered afterregisterReportMocks()so it intercepts first);widgets-toolkit'sregister-report-mocks.tsis left untouched. There is no comparison period, soWithComparisonrenders identically toDefault— documented in the story.Related product discussion/links
Does this pull request change what data or activity we track or use?
No. It reuses the existing
statsproxy endpoint already consumed by the dashboard.Testing instructions
Packages/Premium Analytics/Widgets/AllTimeViewsand confirm the Default, WithComparison, and WidgetDashboardWithWidget stories render the all-time views figure.