Premium Analytics: fix date range calendar click selection#50179
Open
retrofox wants to merge 1 commit into
Open
Premium Analytics: fix date range calendar click selection#50179retrofox wants to merge 1 commit into
retrofox wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
first click starts a new range; half-open draft stays local to the popover
0e9b8de to
59a1d6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes
Fix the date range picker calendar so clicking two days selects the expected range.
With a complete range already selected, react-day-picker's default click behavior never restarts the range: it moves the endpoint nearest to the clicked day.
Clicking an intended start date inside the current range only moved the range's end, and clicking the intended end moved it again, so the two clicks could cancel out exactly and leave the original range untouched.
DateRangePopoverContentnow implements the selection explicitly from the clicked day (triggerDate)The first calendar click starts a new range, the second click completes it (endpoints are ordered, so clicking backward works too).
The in-progress half-open range is held locally in the popover ...
...and rendered by the calendar and the From/To inputs; consumers keep receiving complete ranges only, so the
from && toguards inuseReportDateFiltersandReportParamsFieldare unaffected.Picking a preset or editing the From/To inputs clears any in-progress selection.
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Storybook
cd projects/js-packages/storybook && pnpm run storybook:devPackages/Premium Analytics/UI/DateRangePopover→Defaultand open the popover.App
Before
Screen.Recording.2026-07-02.at.5.15.14.PM.mov
After
Screen.Recording.2026-07-02.at.5.15.32.PM.mov
In the app (
jetpack build packages/premium-analytics, then wp-admin →?page=jetpack-premium-analytics): repeat the same clicks in the dashboard header date picker, in a widget's edit-mode date field, and on the post-detail page. All three mount the same popover.