Rename class to fix a theme clash.#8852
Merged
Merged
Conversation
jeherve
added
Bug
jeherve
reviewed
Feb 15, 2018
Member
jeherve
left a comment
jeherve
left a comment
There was a problem hiding this comment.
Minor comment, just to make sure we don't have the issue again?
| /** | ||
| * Beaverbuilder Compatibility. | ||
| */ | ||
| class BeaverBuilderCompat { |
Member
There was a problem hiding this comment.
What do you think about using something like Jetpack_BeaverBuilderCompat instead, just to be sure this does not happen again in the future?
Author
There was a problem hiding this comment.
Yea im happy with that, i'll update the pr.
jeherve
added
[Status] Needs Author Reply
jeherve
added
[Status] Needs Review
jeherve
added
[Status] Ready to Merge
kraftbj
removed
the
[Status] Ready to Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8851
Changes proposed in this Pull Request:
Simply changing classname.