Fix for compatibility with other compilers/environments#45
Closed
suzuryo3893 wants to merge 2 commits intoAutonomyLab:masterfrom
Closed
Fix for compatibility with other compilers/environments#45suzuryo3893 wants to merge 2 commits intoAutonomyLab:masterfrom
suzuryo3893 wants to merge 2 commits intoAutonomyLab:masterfrom
Conversation
Contributor
suzuryo3893
commented
Jul 30, 2019
suzuryo3893
commented
- An initialization of a variable required. An undefined value results doing nothing in a switch-case statement.
- Explicit settings for all options of serial communication including stop bits, character size, and parity are required.
Otherwize, it can be happened that Operation "7" (0x07) turns to be "135" (0x87)
jacobperron
reviewed
Aug 21, 2019
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Thanks for the patch!
I have a few nitpicks.
| using namespace boost::asio; | ||
| port.open(portName); | ||
| port.set_option(serial_port::baud_rate(baud)); | ||
| port.set_option(serial_port::baud_rate(baud)); |
Member
There was a problem hiding this comment.
nitpick: use spaces instead of tabs
| namespace create { | ||
|
|
||
| SerialStream::SerialStream(boost::shared_ptr<Data> d, const uint8_t& header) : Serial(d), headerByte(header){ | ||
| SerialStream::SerialStream(boost::shared_ptr<Data> d, const uint8_t& header) : Serial(d), headerByte(header), readState(READ_HEADER){ |
Member
There was a problem hiding this comment.
nitpick: Better to initialize readState before headerByte so they are in the order they are defined in the class.
Merged
Member
|
I've addressed my own nitpicks in #50. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.