Catch Boost Exceptions + Address some warnings#69
Merged
jacobperron merged 2 commits intoAutonomyLab:masterfrom Oct 4, 2022
Merged
Catch Boost Exceptions + Address some warnings#69jacobperron merged 2 commits intoAutonomyLab:masterfrom
jacobperron merged 2 commits intoAutonomyLab:masterfrom
Conversation
jacobperron
approved these changes
Oct 4, 2022
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
LGTM, thanks for contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR addresses a couple of (minor) issues I ran into while test driving this library. Otherwise, it's working great so far!
Changes:
Serial, wrap try/catch around boost asio calls that throwstatic_castenum to uint8 instead of implicit (this was coming up as a compile error for me)fabs->std::absin a couple places (compile warnings)Serialchild classes (compile warnings)