Skip to content

Added Average_Copier strategy (no tests sorry) - #2

Merged
drvinceknight merged 5 commits into
Axelrod-Python:masterfrom
geraintpalmer:master
Feb 18, 2015
Merged

Added Average_Copier strategy (no tests sorry)#2
drvinceknight merged 5 commits into
Axelrod-Python:masterfrom
geraintpalmer:master

Conversation

@geraintpalmer

Copy link
Copy Markdown
Member

No description provided.

@drvinceknight

Copy link
Copy Markdown
Member

@geraintpalmer my polite 'dont worry if there are no tests' doesn't apply for you: write a test :)

@geraintpalmer

Copy link
Copy Markdown
Member Author

done I think.

@drvinceknight

Copy link
Copy Markdown
Member

Looks good @geraintpalmer , you have commited your .DS_Store files though. Can you remove these from the history (ask @JasYoung314 how to do that) and add them to the gitignore (this shows the danger of add . or similar).

I'm guessing all tests have passed? Once you've done that I'll merge.

@drvinceknight

Copy link
Copy Markdown
Member

Seems like you managed to remove some of the .DS_Store files but that there's one left: can you do whatever you did to that one? (Click on Files changed on this page and you'll see what I mean).

@geraintpalmer

Copy link
Copy Markdown
Member Author

thats not showing up on mine; no .DS_Store files there

@drvinceknight

Copy link
Copy Markdown
Member

Cool, I'll just merge it and we'll see what happens. Thanks Geraint! Nice
strategy, I look forward to the learning one.

On Wed Feb 18 2015 at 21:55:25 Geraint Palmer notifications@github.com
wrote:

thats not showing up on mine; no .DS_Store files there


Reply to this email directly or view it on GitHub
https://github.com/drvinceknight/Axelrod/pull/2#issuecomment-74956419.

drvinceknight added a commit that referenced this pull request Feb 18, 2015
Added Average_Copier strategy.
@drvinceknight
drvinceknight merged commit 14721f7 into Axelrod-Python:master Feb 18, 2015
@geraintpalmer

Copy link
Copy Markdown
Member Author

Thanks. Sorry for being a pain. Making strategies are fun!

@drvinceknight

Copy link
Copy Markdown
Member

Not at all a pain: I appreciate you taking the time. But be aware with git add .: don't do it basically.

On Wed Feb 18 2015 at 21:58:22 Geraint Palmer notifications@github.com
wrote:

Thanks. Sorry for being a pain. Making strategies are fun!


Reply to this email directly or view it on GitHub
https://github.com/drvinceknight/Axelrod/pull/2#issuecomment-74956988.

marcharper added a commit that referenced this pull request Sep 21, 2015
drvinceknight pushed a commit to drvinceknight/Axelrod that referenced this pull request Nov 16, 2016
meatballs pushed a commit that referenced this pull request Mar 25, 2017
Update test_worse_and_worse.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants