UnverifiedData serialization fix#170
Merged
Merged
Conversation
benesjan
marked this pull request as draft
April 4, 2023 14:04
benesjan
marked this pull request as ready for review
April 4, 2023 14:23
sirasistant
approved these changes
Apr 4, 2023
Contributor
|
LGTM |
ludamad
pushed a commit
that referenced
this pull request
Apr 14, 2023
* fix: update index to uint32 * fix --------- Co-authored-by: cheethas <urmasurda@gmail.com>
ludamad
pushed a commit
that referenced
this pull request
Apr 17, 2023
* fix: update index to uint32 * fix --------- Co-authored-by: cheethas <urmasurda@gmail.com>
ludamad
pushed a commit
that referenced
this pull request
Apr 17, 2023
* fix: update index to uint32 * fix --------- Co-authored-by: cheethas <urmasurda@gmail.com>
ludamad
pushed a commit
that referenced
this pull request
Jul 14, 2023
… to return the x and y coos (#170) Co-authored-by: kevaundray <kevtheappdev@gmail.com>
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
… to return the x and y coos (#170) Co-authored-by: kevaundray <kevtheappdev@gmail.com>
5 tasks
AztecBot
added a commit
that referenced
this pull request
Jul 15, 2026
Replay onto public `next` of **AztecProtocol/aztec-packages-private#623** (forward-port of the private `#170`, *feat: vendor bignum/bigcurve deps with fixes*), applied from a text-only patch since the source PR lives in the private repo. ## What this does - **Vendors** `noir-bignum-external-audit-fixes` + `noir_bigcurve-post-audit-fixes` into `noir-projects/noir-protocol-circuits/crates/{bignum,bigcurve}`. - **Repoints** the `blob` and `rollup-lib` deps from the git tags (`bignum v0.10.0` / `bigcurve v0.14.0`) to the vendored local paths. - **Fixes** the blob `point_compression` test: the regenerated BLS12-381 offset generator uses the opposite square root, so the hardcoded `is_greater` expected flag flips `true`→`false` (the dependent test fix `#328` from the private stack). 92 files, +28,486 / −6. The diff applied cleanly onto `origin/next` (`632095c`) with `git apply --3way` (exit 0). ##⚠️ Regen debt — `pinned-build.tar.gz` `noir-projects/noir-protocol-circuits/pinned-build.tar.gz` is **deliberately excluded** (a ~70 MB binary). The vendored crates change the blob/rollup circuits, so this artifact **must be regenerated with this repo's own bb/noir** — the private tarball is not portable. CI's pinned-build check will flag it; I'll regenerate it while babysitting CI. Draft until then. ## Notes - No local toolchain here to compile the vendored crates against `next`'s noir — CI is the first real compile. - The source commit carried a `Closes #314` that pointed at a **private-repo** tracker; not copied here to avoid closing an unrelated public issue. Refs AztecProtocol/aztec-packages-private#314, AztecProtocol/aztec-packages-private#170. `ci-no-fail-fast` applied. --- *Created by [claudebox](https://claudebox.work/v2/sessions/d48394deee2dda17) · group: `slackbot`* Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UnverifiedData serialization was broken so I first wrote a unit test for it and then fixed.
Checklist: