fix: use standard serialized vector of frs in function tree cbinds#314
Merged
Conversation
…alization logic for leaf frs
dbanks12
changed the title
Collaborator
|
Lgtm
…On Thu, Apr 20, 2023, 10:36 AM David Banks ***@***.***> wrote:
Description
Please provide a paragraph or two giving a summary of the change,
including relevant motivation and context.
Checklist:
- I have reviewed my diff in github, line by line.
- Every change is related to the PR description.
- I have linked
<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue>
this pull request to the issue(s) that it resolves.
- There are no unexpected formatting changes, superfluous debug logs,
or commented-out code.
- The branch has been merged or rebased against the head of its merge
target.
- I'm happy for the PR to be merged at the reviewer's next convenience.
------------------------------
You can view, comment on, or merge this pull request online at:
#314
Commit Summary
- 1b5402b
<1b5402b>
use a plain old serialized vector of frs instead of doing manual
serialization logic for leaf frs
File Changes
(3 files <https://github.com/AztecProtocol/aztec3-packages/pull/314/files>
)
- *M* circuits/cpp/src/aztec3/circuits/abis/c_bind.cpp
<https://github.com/AztecProtocol/aztec3-packages/pull/314/files#diff-2496d2735ce4a0673043dbad1ea49b3f587eaf49a20d71564b22b3e4b06830a4>
(142)
- *M* circuits/cpp/src/aztec3/circuits/abis/c_bind.h
<https://github.com/AztecProtocol/aztec3-packages/pull/314/files#diff-34a02ce73ffd12364262c25c93b85d9a3630fa4e1521ad6b904033ef751874f7>
(2)
- *M* circuits/cpp/src/aztec3/circuits/abis/c_bind.test.cpp
<https://github.com/AztecProtocol/aztec3-packages/pull/314/files#diff-47a2dd92ffb322c6257ec1a891c98471db1b54be7bd0d75c39a4a3aa328e64cd>
(92)
Patch Links:
- https://github.com/AztecProtocol/aztec3-packages/pull/314.patch
- https://github.com/AztecProtocol/aztec3-packages/pull/314.diff
—
Reply to this email directly, view it on GitHub
<#314>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABIBGIQCAYMEDENIMTEPCLXCFCWBANCNFSM6AAAAAAXFTFPQM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
added 6 commits
April 20, 2023 20:33
…cbind. enforce args length. update snapshots
6 tasks
dbanks12
marked this pull request as ready for review
April 21, 2023 13:11
Maddiaa0
reviewed
Apr 21, 2023
| // fill in nonzero leaves to start | ||
| read(function_leaves_in, leaves); | ||
| // fill in zero leaves to complete tree | ||
| NT::fr zero_leaf = FunctionLeafPreimage<NT>().hash(); // hash of empty/0 preimage |
Contributor
There was a problem hiding this comment.
Do we eventually want to have this also be 0, as we did for the NullifierTree?
Contributor
Author
There was a problem hiding this comment.
Not sure, what are advantages of each way?
Maddiaa0
approved these changes
Apr 21, 2023
added 2 commits
April 21, 2023 17:16
…ad of only the object with toBuffer.
Maddiaa0
approved these changes
Apr 21, 2023
AztecBot
added a commit
that referenced
this pull request
Jul 15, 2026
Replay onto public `next` of **AztecProtocol/aztec-packages-private#623** (forward-port of the private `#170`, *feat: vendor bignum/bigcurve deps with fixes*), applied from a text-only patch since the source PR lives in the private repo. ## What this does - **Vendors** `noir-bignum-external-audit-fixes` + `noir_bigcurve-post-audit-fixes` into `noir-projects/noir-protocol-circuits/crates/{bignum,bigcurve}`. - **Repoints** the `blob` and `rollup-lib` deps from the git tags (`bignum v0.10.0` / `bigcurve v0.14.0`) to the vendored local paths. - **Fixes** the blob `point_compression` test: the regenerated BLS12-381 offset generator uses the opposite square root, so the hardcoded `is_greater` expected flag flips `true`→`false` (the dependent test fix `#328` from the private stack). 92 files, +28,486 / −6. The diff applied cleanly onto `origin/next` (`632095c`) with `git apply --3way` (exit 0). ##⚠️ Regen debt — `pinned-build.tar.gz` `noir-projects/noir-protocol-circuits/pinned-build.tar.gz` is **deliberately excluded** (a ~70 MB binary). The vendored crates change the blob/rollup circuits, so this artifact **must be regenerated with this repo's own bb/noir** — the private tarball is not portable. CI's pinned-build check will flag it; I'll regenerate it while babysitting CI. Draft until then. ## Notes - No local toolchain here to compile the vendored crates against `next`'s noir — CI is the first real compile. - The source commit carried a `Closes #314` that pointed at a **private-repo** tracker; not copied here to avoid closing an unrelated public issue. Refs AztecProtocol/aztec-packages-private#314, AztecProtocol/aztec-packages-private#170. `ci-no-fail-fast` applied. --- *Created by [claudebox](https://claudebox.work/v2/sessions/d48394deee2dda17) · group: `slackbot`* Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
readin c_binds, rather than custom buffer manipulation aztec3-circuits#203args#321Contents
frs using standard serializationserializeBufferArrayToVectoragain for cbind args now that C++ expects vectorsnum_leavesarg (not necessary since size of vec is first word of serialization)Checklist: