Update+ improvements Usagesummary.ps1#591
Merged
Merged
Conversation
Added 3 missing metrics. Changed the logic for retrieving usage: . Created an array with the list of all subscriptions . Changed the get-azsSubscriberUsage to include the subscriberID. This way we will have better performance, avoiding gateway timeout errors while executing the sql query.
Contributor
Author
|
any feedback on this? |
Contributor
Author
|
#sign-off |
Contributor
Author
|
any update on this PR? |
cblackuk
suggested changes
May 13, 2021
cblackuk
left a comment
cblackuk
left a comment
Contributor
There was a problem hiding this comment.
Good changes, but need a few tiny fixes - IMHO :-)
pappleby64
approved these changes
Jun 21, 2021
pappleby64
left a comment
pappleby64
left a comment
Contributor
There was a problem hiding this comment.
Look like good changes - agree with other comments
Member
|
@CarlosGon could you pls address the comments? Can you pls make the PR to the az branch as well? |
format VScode
Contributor
Author
|
@bganapa |
CarlosGon
added a commit
to CarlosGon/AzureStack-Tools
that referenced
this pull request
Dec 10, 2021
inline with Azure#591
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 3 missing metrics.
Changed the logic for retrieving usage:
. Created an array with the list of all subscriptions
. Changed the get-azsSubscriberUsage to include the subscriberID.
This way we will have better performance, avoiding gateway timeout errors while executing the sql query.