Bump mysql2 from 3.23.4 to 3.24.2 - #2753
Conversation
Bumps [mysql2](https://github.com/sidorares/node-mysql2) from 3.23.4 to 3.24.2. - [Release notes](https://github.com/sidorares/node-mysql2/releases) - [Changelog](https://github.com/sidorares/node-mysql2/blob/master/Changelog.md) - [Commits](sidorares/node-mysql2@v3.23.4...v3.24.2) --- updated-dependencies: - dependency-name: mysql2 dependency-version: 3.24.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Copilot This PR was opened by Dependabot. Please take it the rest of the way before it's ready for human review:
|
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Addressed in 13f3c12. Impact: |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Suppressed comments (2)
tests/blob/sqlBlobMetadataStorePool.test.ts:155
- This test is intended to validate the mysql2 three-byte length-coded parameter fix, but as written it will also run (and potentially pass without exercising mysql2) for non-MySQL SQL backends (e.g., mssql://). Consider skipping unless AZURITE_TEST_DB is a MySQL connection URI, and use an explicit boundary size (0x10000) to make the intent unambiguous.
it("executes a three-byte length-coded parameter", async () => {
const value = "x".repeat(0x10000 + 1);
const result = await getSequelize(store).query<{ value: string }>(
"SELECT $value AS value",
ChangeLog.md:9
- The new changelog entry claims "large parameter persistence", but the added regression coverage only validates round-tripping a large bound parameter via a SELECT (no persistence operations are performed). Rewording this avoids implying behavior that isn’t actually covered by the changes in this PR.
- Updated lockfile-resolved `mysql2` from 3.23.4 to 3.24.2 to correct three-byte length-coded parameter encoding and improve SQL metadata-store performance; added SQL pool regression coverage for large bound parameters.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
tests/blob/sqlBlobMetadataStorePool.test.ts:165
- Using
$valuein the raw SQL string is a non-standard bind placeholder for Sequelize and can be treated as a literal (or otherwise not bound) for the mysql/mariadb dialects. To reliably exercise driver-level parameter binding (and the mysql2 length-coded encoding), use a positional placeholder (?) with an arraybindinstead.
const result = await sequelize.query<{ value: string }>(
"SELECT $value AS value",
{
bind: { value },
type: QueryTypes.SELECT
}
Copilot, Could you please handle this? |
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Bumps mysql2 from 3.23.4 to 3.24.2.
Release notes
Sourced from mysql2's releases.
Changelog
Sourced from mysql2's changelog.
Commits
649e129chore(master): release 3.24.2 (#4504)87579e1test: cover length-coded parameter sizes at the 0xFD boundary (#4503)1dcd8effix(promise): honourtrace: falseon every promise-API method (#4502)de56272fix: correct length-coded number size for the 3-byte range (#4500)ca10232chore(master): release 3.24.1 (#4496)183e947perf: single-pass utf8 string encoding for outgoing packets (#4495)fabc3bcchore(master): release 3.24.0 (#4492)f3a60bcperf: serialize COM_STMT_EXECUTE in a single exact-size pass (#4494)493f9ecci: pin EXPLAIN to FORMAT=TRADITIONAL for MySQL 9.5+ (#4493)c86fe5aperf: remove per-query and per-row allocation hotspots (#4486)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)