Closed
Conversation
anuchandy
changed the title
github-merge-queue bot
pushed a commit
to microsoft/typespec
that referenced
this pull request
Apr 3, 2025
This PR addresses a regression introduced in the [PR](#6737). In 6737, a `List<MethodTransformationDetails>` representing mappings were replaced with a new type `ParameterTransformations` that composes an `immutable` list of mapping. The original list was the JDK `ArrayList<>` that internally implements `equals()` and `hashcode()` (e.g., those equality impl ensures different list with zero elements as equal). The new type `ParameterTransformations` introduced inherits the `equals()` and `hashcode()` from `Object`, so two distinct references are always different. Additionally, the composed `immutable` list is JDK `ImmutableList`, unlike `ArrayList`, it doesn’t not implement `equals()` and `hashcode()` but inherits Object's. The `ClientMethod` composes `ParameterTransformations ` (earlier `List< MethodTransformationDetails >`) property. The generator needs to find distinct list of `ClientMethods`, and the proper comparison requires all composed properties type to support equality checks. So, with changes 6737, there were duplicate `ClientMethod`, resulting in emitted Java class to have same function appears twice. Fixes: Azure/autorest.java#3061 Autorest [PR](Azure/autorest.java#3063)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.