[Java] Fixes regression in method parameter transformation#6864
Merged
anuchandy merged 1 commit intomicrosoft:mainfrom Apr 4, 2025
Merged
[Java] Fixes regression in method parameter transformation#6864anuchandy merged 1 commit intomicrosoft:mainfrom
anuchandy merged 1 commit intomicrosoft:mainfrom
Conversation
anuchandy
requested review from
XiaofeiCao,
haolingdong-msft,
srnagar and
weidongxu-microsoft
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:java
Contributor
|
No changes needing a change description found. |
anuchandy
commented
Apr 3, 2025
...icrosoft/typespec/http/client/generator/core/model/clientmodel/ParameterTransformations.java
Show resolved
Hide resolved
Collaborator
|
You can try these changes here
|
weidongxu-microsoft
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a regression introduced in the PR.
In 6737, a
List<MethodTransformationDetails>representing mappings were replaced with a new typeParameterTransformationsthat composes animmutablelist of mapping.The original list was the JDK
ArrayList<>that internally implementsequals()andhashcode()(e.g., those equality impl ensures different list with zero elements as equal).The new type
ParameterTransformationsintroduced inherits theequals()andhashcode()fromObject, so two distinct references are always different. Additionally, the composedimmutablelist is JDKImmutableList, unlikeArrayList, it doesn’t not implementequals()andhashcode()but inherits Object's.The
ClientMethodcomposesParameterTransformations(earlierList< MethodTransformationDetails >) property.The generator needs to find distinct list of
ClientMethods, and the proper comparison requires all composed properties type to support equality checks. So, with changes 6737, there were duplicateClientMethod, resulting in emitted Java class to have same function appears twice.Fixes: Azure/autorest.java#3061
Autorest PR