[Java] Consolidates all operation parameters transformation and inspection#6737
Merged
anuchandy merged 6 commits intomicrosoft:mainfrom Apr 1, 2025
Merged
Conversation
anuchandy
requested review from
XiaofeiCao,
haolingdong-msft,
srnagar and
weidongxu-microsoft
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:java
Contributor
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
anuchandy
force-pushed
the
param-transformation-improv
branch
from
d619ccb to
621f3ec
Compare
weidongxu-microsoft
previously approved these changes
Mar 28, 2025
.../microsoft/typespec/http/client/generator/core/mapper/ParametersTransformationProcessor.java
Show resolved
Hide resolved
anuchandy
force-pushed
the
param-transformation-improv
branch
from
621f3ec to
9c9eb6d
Compare
… useful methods to ParameterTransformation, and introduce ParameterTransformations to hold collection of ParameterTransformation with functions inspect this inner collection.
anuchandy
force-pushed
the
param-transformation-improv
branch
from
2aa65b2 to
5928f71
Compare
anuchandy
force-pushed
the
param-transformation-improv
branch
from
5928f71 to
455e40a
Compare
anuchandy
force-pushed
the
param-transformation-improv
branch
from
c4fa34d to
055bfc0
Compare
weidongxu-microsoft
approved these changes
Apr 1, 2025
mario-guerra
pushed a commit
that referenced
this pull request
Apr 2, 2025
…ction (#6737) This pull-request, 1. consolidates all operation parameters transformation and inspection of those transformations from various parts of the code. 2. adds extensive Java documentation focusing generator devs. 3. couple of conditional checks have been simplified when possible. With this pull request, we have slightly reduced the amount of code in `ClientMethodMapper` and a few other places. No behavior changes are introduced. Autorest verification pr: Azure/autorest.java#3055
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 4, 2025
This PR addresses a regression introduced in the [PR](#6737). In 6737, a `List<MethodTransformationDetails>` representing mappings were replaced with a new type `ParameterTransformations` that composes an `immutable` list of mapping. The original list was the JDK `ArrayList<>` that internally implements `equals()` and `hashcode()` (e.g., those equality impl ensures different list with zero elements as equal). The new type `ParameterTransformations` introduced inherits the `equals()` and `hashcode()` from `Object`, so two distinct references are always different. Additionally, the composed `immutable` list is JDK `ImmutableList`, unlike `ArrayList`, it doesn’t not implement `equals()` and `hashcode()` but inherits Object's. The `ClientMethod` composes `ParameterTransformations ` (earlier `List< MethodTransformationDetails >`) property. The generator needs to find distinct list of `ClientMethods`, and the proper comparison requires all composed properties type to support equality checks. So, with changes 6737, there were duplicate `ClientMethod`, resulting in emitted Java class to have same function appears twice. Fixes: Azure/autorest.java#3061 Autorest [PR](Azure/autorest.java#3063)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request,
With this pull request, we have slightly reduced the amount of code in
ClientMethodMapperand a few other places. No behavior changes are introduced.Autorest verification pr: Azure/autorest.java#3055