-
Notifications
You must be signed in to change notification settings - Fork 260
fix: [NPM] V2 NPM (with only linux data plane) bug fix after first run #1120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
previously approved these changes
Nov 22, 2021
JungukCho
previously approved these changes
Nov 22, 2021
4514a1e
3 tasks
This reverts commit 4514a1e.
Co-authored-by: jungukcho <jungukcho@microsoft.com>
30e13a4 to
c10e3d1
Compare
vakalapa
approved these changes
Dec 1, 2021
Contributor
vakalapa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great effort finding all the issues!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
After running conformance test, fix finding issues.
Had a bug where we were jumping to AZURE-NPM-EGRESS chain instead. We need to jump to this other chain since the ingress allow mark will prevent us from returning to ingress chain again after a no-op pass through egress chain.
Observed multiple restarting NPM. Checked log and there is nil pointer errors in
NPMSimpleError.nilerror.unspecifiedandAnyipset restore, we would try to destroy sets before deleting any references to them in listsipset restorefileFix duplicated
namedPortprefix.Fix translating
egress (previously included only the default drop rule)egressnomatchinformation in ipblockwindowspart. Please revisewindowsif needed.Will update the NPMNetworkPolicy struct to just have one of these fields eventually instead of the two.
uses conventional commit messages
includes documentation
adds unit tests
Notes: