Skip to content

fix: [NPM] V2 NPM with linux DP bug fix after first run #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: [NPM] V2 NPM with linux DP bug fix after first run #1123

wants to merge 2 commits into from

Conversation

@JungukCho
Copy link
Contributor

@JungukCho JungukCho commented Nov 22, 2021 •
edited
Loading

Reason for Change:

After running conformance test, fix finding issues.

  1. Observed multiple restarting NPM. Checked log and there is nil pointer errors in NPMSimpleError.

Issue Fixed:

Requirements:

Notes:
TODO list.

  1. For the first error, we need to UT to catch this nil error.
  2. I will resolve lint warning in next PR.

@JungukCho
Copy link
Contributor Author

JungukCho commented Nov 23, 2021

close this PR since we made decision to deal with this in #1120

@JungukCho JungukCho closed this Nov 23, 2021
@JungukCho JungukCho requested review from matmerr, neaggarwMS and vakalapa and removed request for huntergregory, matmerr, neaggarwMS and vakalapa November 23, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neaggarwMS neaggarwMS Awaiting requested review from neaggarwMS

@vakalapa vakalapa Awaiting requested review from vakalapa

Assignees

No one assigned

Labels

bug npm Related to NPM. work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JungukCho