create nnc listener concept and adapt existing poolmonitor and swift … #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…service to it Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr
added
cns
rbtr
requested review from
rsagasthya and
thatmattlong
and removed request for
a team
3 tasks
|
|
||
| type NodeNetworkConfigListenerFunc func(*v1alpha.NodeNetworkConfig) error | ||
|
|
||
| func (f NodeNetworkConfigListenerFunc) Update(nnc *v1alpha.NodeNetworkConfig) error { |
Collaborator
There was a problem hiding this comment.
neat, haven't seen this pattern much but seems pretty clean to me
Collaborator
Author
There was a problem hiding this comment.
it is a little on the abstract side, but it is cleaner than needing to attach these funcs to a stub struct as methods when the right closure provides all the context we need. it's the same pattern as http.Handler/http.HandlerFunc 🙂
| } | ||
| responseCode := cnscli.CreateOrUpdateNetworkContainerInternal(&ncRequest) | ||
| err = restserver.ResponseCodeToError(responseCode) | ||
| if err != nil { |
Collaborator
There was a problem hiding this comment.
can combine if err := restserver.ResponseCode ...; err != nil
Collaborator
Author
There was a problem hiding this comment.
incorporated this in the next one
thatmattlong
approved these changes
Apr 12, 2022
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
…service to it (Azure#1323) Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…service to it
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
Issue Fixed:
Requirements:
Notes: