Support NetworkContainers of Static or Dynamic types #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested review from
rsagasthya and
thatmattlong
and removed request for
a team
thatmattlong
requested changes
Apr 12, 2022
Collaborator
thatmattlong
left a comment
thatmattlong
left a comment
There was a problem hiding this comment.
Don't need to reserve first IP of CIDR
rbtr
force-pushed
the
overlay-cidrizer
branch
2 times, most recently
from
9bad326 to
2479485
Compare
thatmattlong
previously approved these changes
Apr 14, 2022
rbtr
force-pushed
the
overlay-cidrizer
branch
2 times, most recently
from
91a0551 to
3b63709
Compare
rbtr
force-pushed
the
overlay-cidrizer
branch
5 times, most recently
from
a23bad0 to
987f9fa
Compare
rbtr
changed the title
neaggarwMS
reviewed
Apr 15, 2022
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
neaggarwMS
previously requested changes
Apr 18, 2022
| return errors.Wrap(err, "provider failed to provide PodInfoByIP") | ||
| } | ||
| for i := range nnc.Status.NetworkContainers { | ||
| ncRequest, err := kubecontroller.CreateNCRequestFromDynamicNC(nnc.Status.NetworkContainers[i]) |
Member
There was a problem hiding this comment.
shall we change the API name back to CRDStatusToNCRequest?
Collaborator
Author
There was a problem hiding this comment.
no, we're creating the NC Request(s) from the NC(s), not from the Status
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
thatmattlong
approved these changes
Apr 18, 2022
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* add overlay static nnc to nc listener Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * inline err check Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * pass NodeNetworkConfigs to Update method by value Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * rework nnc reconcile flow for NetworkContainer modes Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Depends on #1323
Notes: