-
Notifications
You must be signed in to change notification settings - Fork 260
fix: replace NumCPU with NumCores #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@zhangming870 what's the context? has this just always been wrong and silently ignored, or has something changed in DNC? |
@rbtr We believe it always been wrong, because no one uses it yet. This is for dnc in managed mode. |
|
good to merge |
|
@zhangming870 can you rebase? there was a fix to the CI which should improve your check results 🙂 |
|
@rbtr sure. rebased. |
|
@zhangming870 looks like something messed up the commit history: https://github.com/Azure/azure-container-networking/pull/1358/commits |
rbtr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit history needs to be fixed
|
@rbtr rebased again and did a sync branch, I guess it pushed history to remote. thanks for letting me know how to do that. And please let me know if anything still wrong. |
88c7ba5 to
183fd0a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… in dnc side (Azure#1358) Co-authored-by: Ming Zhang <zhangming@microsoft.com>
Reason for Change:
replace NumCPU with NumCores, so that it can be correctly decode in dnc side.
Issue Fixed:
wrong request field name, should use NumCores instead of NumCPU
Requirements:
Notes: