Skip to content

fix: replace NumCPU with NumCores #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2022
Merged

fix: replace NumCPU with NumCores #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
183fd0a
change the field name to NumCores, so that it can be correctly decode…
May 3, 2022
6569fea
fix lint issue
May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cns/NetworkContainerContract.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,6 @@ type NodeInfoResponse struct {

// NodeRegisterRequest - Struct to hold the node register request.
type NodeRegisterRequest struct {
NumCPU int
NumCores int
NmAgentSupportedApis []string
}
2 changes: 1 addition & 1 deletion cns/service/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ func registerNode(httpc *http.Client, httpRestService cns.HTTPService, dncEP, in
nodeRegisterRequest cns.NodeRegisterRequest
)

nodeRegisterRequest.NumCPU = numCPU
nodeRegisterRequest.NumCores = numCPU
supportedApis, retErr := nmagent.GetNmAgentSupportedApis(httpc, "")

if retErr != nil {
Expand Down