reset the http status code to 500 in case we encounter an error #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smittal22
force-pushed
the
smittal-bug-fix
branch
from
f985aa2 to
a752275
Compare
ashvindeodhar
previously approved these changes
Feb 7, 2023
smittal22
force-pushed
the
smittal-bug-fix
branch
from
a752275 to
e28904c
Compare
smittal22
force-pushed
the
smittal-bug-fix
branch
from
e28904c to
829e832
Compare
smittal22
force-pushed
the
smittal-bug-fix
branch
from
829e832 to
c693ffa
Compare
Contributor
Author
|
Since we do not want CNS to make any decisions and just pass the encoded response from NMA to DNC, we should not handle this bug in the manner this PR does. Closing this PR. It will be handled here: #1799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
During NC publish and unpublish, we do not reset the httpStatusCode that we return back to DNC. As a result, even if we encounter an error we send back HTTP 200 back to DNC
Issue Fixed:
https://msazure.visualstudio.com/DefaultCollection/One/_workitems/edit/17035213
Requirements:
Notes: