Skip to content

reset the http status code to 500 in case we encounter an error #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

reset the http status code to 500 in case we encounter an error #1787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cns/restserver/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1239,6 +1239,10 @@ func (service *HTTPRestService) publishNetworkContainer(w http.ResponseWriter, r
returnCode = types.UnsupportedVerb
}

if returnCode != 0 {
publishStatusCode = http.StatusInternalServerError
}

// create a synthetic response from NMAgent so that clients that previously
// relied on its presence can continue to do so.
publishResponseBody := fmt.Sprintf(`{"httpStatusCode":"%d"}`, publishStatusCode)
Expand Down Expand Up @@ -1350,6 +1354,10 @@ func (service *HTTPRestService) unpublishNetworkContainer(w http.ResponseWriter,
returnCode = types.UnsupportedVerb
}

if returnCode != 0 {
unpublishStatusCode = http.StatusInternalServerError
}

// create a synthetic response from NMAgent so that clients that previously
// relied on its presence can continue to do so.
unpublishResponseBody := fmt.Sprintf(`{"httpStatusCode":"%d"}`, unpublishStatusCode)
Expand Down